General: Smaller fixes and typos #2950
Conversation
| class ValidateWorkfilePath(pyblish.api.InstancePlugin): | ||
| """Validate existence of workfile instance existence.""" | ||
|
|
||
| label = "Collect Workfile" | ||
| label = "Validate Workfile" | ||
| order = pyblish.api.ValidatorOrder - 0.49 | ||
| families = ["workfile"] | ||
| hosts = ["traypublisher"] |
There was a problem hiding this comment.
Noting this here even though it's somewhat unrelated to this PR.
This particular plug-in checks sourceFilepath in data. A quick query over the code base shows that ONLY this validator and collector use that particular instance.data. It doesn't appear to be used for any output, etc.
Could we somehow make to this more generic so that there's no need for this additional data key for this single use case but we could do e.g. a validator over all instance.data[representation] and its files? (even though most representations get added during Extractors after Validator).
Validating our input content exists seems like something we (need to do or are doing) elsewhere too so I imagine we might want to unify where possible?
There was a problem hiding this comment.
The whole logic of traypublisher will be more generic, but not in this PR.
Brief description
Fix of few smaller issues.
Description
Fixed import of attribute definitions in tray publisher plugin. Fixed typo of attribute
_first_show. Log information about not find icon and also log that passed icon name is not exact match of used icon name (prefix from qtawesome was added). ChangedName:label toVariant:in creator dialog window.Testing notes:
Variant:instead ofName: