This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Houdini: Fix FPS + outdated content pop-ups #3079
Merged
+50
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This now also improves the label/popup in Maya and actually shows the current FPS and what FPS it expected to have. Ready for testing. |
antirotor
approved these changes
Apr 22, 2022
antirotor
added
host: Maya
host: Houdini
type: enhancement
Agreed - Let's fix this together with the other UX notes related to the pop-ups. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
This fixes #3069
Description
Fixed the signals + added some docstrings to Popup classes.
Additional info
We should still unify these popups more across all hosts with potentially better UX approach too as came up in #1780 in this comment.
Testing notes: