This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Hiero: Initial frame publish support #3106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: OP-2831 Hiero: Initial frame publish support |
jakubjezek001
added
host: Hiero
type: feature
tokejepsen
approved these changes
Apr 27, 2022
jakubjezek001
commented
Apr 28, 2022
|
|
||
| # filter out all unepropriate instances | ||
| if not instance.data["publish"]: | ||
| continue | ||
|
|
||
| # exclude other families then self.families with intersection | ||
| if not set(self.families).intersection([family]): | ||
| if not set(self.families).intersection(set(families + [family])): |
There was a problem hiding this comment.
@tokejepsen this is just an improvement of the code. The test was only performed on main family and not on additional families.
jakubjezek001
commented
Apr 28, 2022
| # "marginIn": 1, | ||
| # "marginOut": 1 | ||
| # } | ||
| # }, |
There was a problem hiding this comment.
@tokejepsen this was just an old commented code which could be ditched..
64qam
approved these changes
Apr 29, 2022
jakubjezek001
deleted the
feature/OP-2831_Hiero-Initial-frame-publish-support
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Frame family publishing (convert form 2.x)
Description
With the "frame" family tags, you can publish still images from the edit by tagging frames in the sequence.
Original PR:
#1172
Testing notes: