Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

TVPaint: Match renderlayer key with other hosts #3110

Merged
merged 5 commits into from
Apr 29, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Apr 28, 2022

Brief description

Render layer key in TVPaint implementation is without underscode (render_layer -> renderlayer).

Description

Add 'renderlayer' to instance.data for TVPaint render instances. Render passes had render_layer which was changed to renderlayer and layers pass their variant as value. This is to match Maya specifically. There is a secondary reason to do so, to match subset group name filtering. Also usage of render_pass was modified to use renderpass to keep consistency.

Additional info

For some time there must be bost ways how are keys stored. Develop variant of PR.

Testing notes:

  • New files
  1. Open new TVpaint file
  2. Create some render layers/passes
  3. Publish
  4. All should work and if subset group profile is matching, it should be grouped
  • Old files
  1. Open TVPaint file with instances created before this PR
  2. publish
  3. All should work and subset groups should match too

@ynbot
Copy link
Contributor

ynbot commented Apr 28, 2022

Task linked: OP-3132 TVP: group name in loader

@iLLiCiTiT iLLiCiTiT changed the title Enhancement/op 3132 tvp group name in loader dev TVPaint: Match renderlayer key with other hosts Apr 28, 2022
@iLLiCiTiT iLLiCiTiT self-assigned this Apr 28, 2022
@iLLiCiTiT iLLiCiTiT added type: enhancement Enhancements to existing functionality host: TV Paint labels Apr 28, 2022
@iLLiCiTiT iLLiCiTiT requested a review from 64qam April 28, 2022 09:01
@iLLiCiTiT iLLiCiTiT merged commit fbd8aae into develop Apr 29, 2022
@iLLiCiTiT iLLiCiTiT deleted the enhancement/OP-3132_TVP-group-name-in-loader_dev branch April 29, 2022 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: TV Paint type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants