Maya: fix image prefix warning in validator #3128
Conversation
| @@ -92,6 +92,7 @@ def process(self, instance): | |||
| def get_invalid(cls, instance): | |||
|
|
|||
| invalid = False | |||
| multipart = False | |||
There was a problem hiding this comment.
Looking at all the changes this addition seems redundant.
| multipart = False |
| # remove aov token from prefix to pass validation | ||
| # first resolve it and then remove if dangling | ||
| default_prefix = default_prefix.replace( | ||
| "{aov_separator}", instance.data.get("aovSeparator", "_")) | ||
| default_prefix = default_prefix.rstrip( | ||
| instance.data.get("aovSeparator", "_")) |
There was a problem hiding this comment.
Why first resolve it and then strip the right hand side aov separator tokens, that seems redundant and maybe even not as explicit as one might want. If it's stripping it anyway shouldn't it just replace the explicit {aov_separator} placeholder with an empty string?
| # remove aov token from prefix to pass validation | |
| # first resolve it and then remove if dangling | |
| default_prefix = default_prefix.replace( | |
| "{aov_separator}", instance.data.get("aovSeparator", "_")) | |
| default_prefix = default_prefix.rstrip( | |
| instance.data.get("aovSeparator", "_")) | |
| # remove aov token separator | |
| default_prefix = default_prefix.replace("{aov_separator}", "") |
Additionally, since the image prefix is hardcoded in the validator anyway (doesn't seem to allow to be overridden by settings) this "fix" could even be made more explicit by explicitly replacing the end of the default image prefix alltogether?
We could even get by with just a single re.sub(re.escape("{aov_separator}<RenderPass>") + "$", "", default_prefix)? Or even as simple as prefix = prefix[:-len("{aov_separator}<RenderPass>")] to just strip off the hardcoded end or prefix = prefix.split("{aov_separator}")[0]?
There was a problem hiding this comment.
@antirotor just pinging you here in case you didn't notice
…der-settings-validator-prefix-warning
antirotor
deleted the
bugfix/OP-3171_render-settings-validator-prefix-warning
branch
Fix
This is fixing issue when
Merge AOVoption forces render settings validator to complain about superfluous<RenderPass>token. But if removed, it issues warning about image prefix not being the one recommended.Test
Create scene with render instance, in Render Settings check
Merge AOVsin Arnold settings. Leave prefix as it is. Hit Publish -> Validate. Render Settings Validator should fail on unnecessary<RenderPass>token. Remove it from the prefix, validate again and it should pass.Note
This is quick fix but I think Render Settings validator still needs big overhaul to deal with different renderer settings more gracefully. Ideally providing validator for every renderer.
Close #3127