Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Oiio conversion for ffmpeg checks for invalid characters #3166

Merged
merged 2 commits into from
May 11, 2022
Merged

General: Oiio conversion for ffmpeg checks for invalid characters #3166

merged 2 commits into from
May 11, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Fix check for invalid characters in oiio conversion.

Description

Check for invalid characters never happened because of invalid condition before.

Testing notes:

  1. Create renders with " in some metadata attribute but shorted then 8196 characters
  2. Make it go through ExtractReview plugin
  3. It should not crash on ffmpeg conversion

@iLLiCiTiT iLLiCiTiT self-assigned this May 11, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label May 11, 2022
m-u-r-p-h-y
m-u-r-p-h-y approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted job from Maya2022 using Arnold to render cryptomatte exrs

Publish and extract review works as expected, all mp4 created.

image

@iLLiCiTiT iLLiCiTiT merged commit 6156553 into develop May 11, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/oiio_conversion_chars_check branch May 11, 2022 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@antirotor antirotor Awaiting requested review from antirotor

@64qam 64qam Awaiting requested review from 64qam

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @m-u-r-p-h-y