Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: added clean_import option to Import loader #3181

Merged
merged 2 commits into from
May 19, 2022

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented May 13, 2022

Brief description

By selecting this option all occurrences of cbId of imported nodes will be removed.

Description

Usable for sharing assets between projects.

Testing notes:

  1. Load model via Import loader - set Clean import option (rectangle after Import label)
    2.cbId in Extra Attributes should be removed (also check log for 'Removing ..' in Script Editor)

By selecting this option all occurrences of cbId of imported nodes will be removed.
@kalisp kalisp added type: enhancement Enhancements to existing functionality host: Maya labels May 13, 2022
@kalisp kalisp self-assigned this May 13, 2022
@ynbot
Copy link
Contributor

ynbot commented May 13, 2022

Task linked: OP-3154 regenerate cbID for hierarchy

Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main purpose of this option is to simplify the reuse of assets (from other projects, assets, etc.)

We have to make sure the attributes are removed from all nodes, especially sets, curves (from rigging), etc.

It seems the attribute is removed from the geometry shape only.

image

@BigRoy
Copy link
Collaborator

BigRoy commented May 13, 2022

Usable for sharing assets.

Is it? Because if saving the scene in OpenPype again it will auto-generate new ids. So it's not really easy to use for sharing with e.g. another team outside of the pipeline? Or did you mean sharing assets internally between projects?

Previous one was limiting attribute removal only on shapes, this should remove attribute in more places.
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imported couple of different assets (models, rigs)

and all cbId attributes and all entities were removed successfully

  • shapes
  • transform nodes
  • sets
  • rigs

tested with M2023

@kalisp kalisp merged commit 9bc5a3b into develop May 19, 2022
@kalisp kalisp deleted the enhancement/OP-3154_regenerate-cbID-for-hierarchy branch May 19, 2022 08:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants