Looks: add basic support for Renderman #3190

antirotor · 2022-05-16T10:44:01Z

Feature

This is adding support for renderman shaders and file nodes in look processing.

Testing:

Create look with PxrDiffuse shader and PxrTexture node. It should be correctly collected and published.

⚠️ BUG: there seems to be Maya/Renderman bug that paths in PxrTexture you see in Hypershade won't update automatically. They are set correctly and if queried via cmds.getAttr() you'll get correct result, but UI is updated only when you close and re-open Hypershade. This is main concern for testing because when you load such look in the same session of Maya, you'll get the feeling that texture path will still point to its original location.

Close #3189

ynbot · 2022-05-16T10:44:03Z

Task linked: OP-3256 Maya Looks: support for renderman PxrTexture

BigRoy · 2022-05-16T11:02:25Z

openpype/hosts/maya/plugins/publish/collect_look.py

@@ -165,7 +170,7 @@ def get_file_node_path(node):
 if any(pattern in lower for pattern in patterns):
 return texture_pattern

- if cmds.nodeType(node) == 'aiImage':
+ if cmds.nodeType(node) in ['aiImage', 'PxrTexture']:


Would lookup in set be better?

Suggested change

if cmds.nodeType(node) in ['aiImage', 'PxrTexture']:

if cmds.nodeType(node) in {'aiImage', 'PxrTexture'}:

BigRoy · 2022-05-16T11:02:54Z

openpype/hosts/maya/plugins/publish/collect_look.py

+ if cmds.nodeType(node) not in [
+ "file", "aiImage", "RedshiftNormalMap", "PxrTexture"]:


Also, lookup in set maybe better?

BigRoy · 2022-05-16T11:04:57Z

openpype/hosts/maya/plugins/publish/collect_look.py

+ try:
+ extension = cmds.getAttr('%s.useFrameExtension' % node)
+ except ValueError:
+ extension = None


This should be extension = False to still return a boolean.
Also, might be better as a variable named use_frame_extension?

m-u-r-p-h-y · 2022-05-16T14:44:59Z

There is much more Rendeman native nodes having file I/O

I know this PR adds basic support, but we should at least add the most used ones.

PxrEnvGround
PxrBump
PxrNormalMap
PxrMultiTexture
PxrProjectionLayer
PxrPtexture
PxrTexture
aaOceanPrmanShader
PxrBakePointCloud
PxrBakeTexture
PxrOSL
PxrDomeLight
PxrGoboLightFilter

antirotor · 2022-05-16T16:30:00Z

There is much more Rendeman native nodes having file I/O

I know this PR adds basic support, but we should at least add the most used ones.

True but this is really for another PR - for example PxrMultiTexture is completely another beast that needs some bigger changes (filename0, filename1, ...)

m-u-r-p-h-y · 2022-05-17T08:06:07Z

True but this is really for another PR - for example PxrMultiTexture is completely another beast that needs some bigger changes (filename0, filename1, ...)

I did not make it clear in my previous message. Exactly for that reason, I marked the ones to be included with bold (and later even added italic) but it is not very clear. My bad, sorry about that.

m-u-r-p-h-y · 2022-05-17T08:17:42Z

Just to mention possible custom tokens used in file strings in RfM which could cause troubles down the line . . .

https://rmanwiki.pixar.com/display/RFM23/String+tokens+in+RfM

BigRoy · 2022-05-17T09:04:14Z

Just to mention possible custom tokens used in file strings in RfM which could cause troubles down the line . . .

Ouch - that could definitely make things more complicated. There is rfm2.api.strings.expand_string that can likely help expand most of the parts of the string but might be non trivial for the shape names, etc. etc.
Anyway, validators could be added and everything down the line.

Thanks for mentioning.

BigRoy · 2022-05-18T15:32:50Z

openpype/hosts/maya/plugins/publish/collect_look.py

+DEFAULT_FILE_NODES = frozenset(
+ ["file"]
+)
+
+ARNOLD_FILE_NODES = frozenset(
+ ["aiImage"]
+)
+
+REDSHIFT_FILE_NODES = frozenset(
+ ["RedshiftNormalMap"]
+)
+
+RENDERMAN_FILE_NODES = frozenset(
+ [
+ "PxrBump",
+ "PxrNormalMap",
+ # PxrMultiTexture (need to handle multiple filename0 attrs)
+ "PxrPtexture",
+ "PxrTexture",
+ ]
+)


Would it make more sense to store it like this:

file_nodes = { # Maya "file": "filename", # Arnold "aiImage": "filename", # Redshift "RedshiftNormalMap": "tex0", # Renderman "PxrBump": "filename", "PxrNormalMap": "filename", "PxrPtexture": "filename", "PxrTexture": "filename", # PrxMultiTexture is a special case with multiple filename attributes # So this could maybe be a special function? "PxrMultiTexture": get_pixar_multi_texture } # Example usages node_type = cmds.nodeType(node) attr = file_nodes[node_type] path = cmds.getAttr('{}.{}'.format(node, attr))

Special edge case:

def get_pixar_multi_texture(node): filepaths = [] for path in path_attributes: filepaths.append(path) return filepaths

Somehow feels more manageable overall instead of having the logic spread out as much as it is now?

m-u-r-p-h-y

seems like we are trying to convert ptex textures with maketx

Message: 
Command 'D:\REPO\OpenPype\vendor\bin\oiio\windows\maketx.exe -v -u --unpremult --checknan --oiio --filter lanczos3 -sattrib sourceHash hdrenv,ptx|1262811026,0|5962|maketx  -o C:\Users\murph\AppData\Local\Temp\pyblish_tmp_0rtzfbjq\resources\hdrenv.tx D:\REPO_LIB\PIXAR\hdrenv.ptx' returned non-zero exit status 1.
Line: 
512
Traceback: 
Traceback (most recent call last):
  File "D:\REPO\OpenPype\.venv\lib\site-packages\pyblish\plugin.py", line 522, in __explicit_process
    runner(*args)
  File "D:\REPO\OpenPype\openpype\hosts\maya\plugins\publish\extract_look.py", line 226, in process
  File "D:\REPO\OpenPype\openpype\hosts\maya\plugins\publish\extract_look.py", line 363, in process_resources
  File "D:\REPO\OpenPype\openpype\hosts\maya\plugins\publish\extract_look.py", line 508, in _process_texture
  File "D:\REPO\OpenPype\openpype\hosts\maya\plugins\publish\extract_look.py", line 95, in maketx
  File "C:\Program Files\Autodesk\Maya2022\Python37\lib\subprocess.py", line 411, in check_output
    **kwargs).stdout
  File "C:\Program Files\Autodesk\Maya2022\Python37\lib\subprocess.py", line 512, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command 'D:\REPO\OpenPype\vendor\bin\oiio\windows\maketx.exe -v -u --unpremult --checknan --oiio --filter lanczos3 -sattrib sourceHash hdrenv,ptx|1262811026,0|5962|maketx  -o C:\Users\murph\AppData\Local\Temp\pyblish_tmp_0rtzfbjq\resources\hdrenv.tx D:\REPO_LIB\PIXAR\hdrenv.ptx' returned non-zero exit status 1.

antirotor · 2022-05-19T08:55:35Z

seems like we are trying to convert ptex textures with maketx

Message: 
Command 'D:\REPO\OpenPype\vendor\bin\oiio\windows\maketx.exe -v -u --unpremult --checknan --oiio --filter lanczos3 -sattrib sourceHash hdrenv,ptx|1262811026,0|5962|maketx  -o C:\Users\murph\AppData\Local\Temp\pyblish_tmp_0rtzfbjq\resources\hdrenv.tx D:\REPO_LIB\PIXAR\hdrenv.ptx' returned non-zero exit status 1.
Line: 
512
Traceback: 
Traceback (most recent call last):
  File "D:\REPO\OpenPype\.venv\lib\site-packages\pyblish\plugin.py", line 522, in __explicit_process
    runner(*args)
  File "D:\REPO\OpenPype\openpype\hosts\maya\plugins\publish\extract_look.py", line 226, in process
  File "D:\REPO\OpenPype\openpype\hosts\maya\plugins\publish\extract_look.py", line 363, in process_resources
  File "D:\REPO\OpenPype\openpype\hosts\maya\plugins\publish\extract_look.py", line 508, in _process_texture
  File "D:\REPO\OpenPype\openpype\hosts\maya\plugins\publish\extract_look.py", line 95, in maketx
  File "C:\Program Files\Autodesk\Maya2022\Python37\lib\subprocess.py", line 411, in check_output
    **kwargs).stdout
  File "C:\Program Files\Autodesk\Maya2022\Python37\lib\subprocess.py", line 512, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command 'D:\REPO\OpenPype\vendor\bin\oiio\windows\maketx.exe -v -u --unpremult --checknan --oiio --filter lanczos3 -sattrib sourceHash hdrenv,ptx|1262811026,0|5962|maketx  -o C:\Users\murph\AppData\Local\Temp\pyblish_tmp_0rtzfbjq\resources\hdrenv.tx D:\REPO_LIB\PIXAR\hdrenv.ptx' returned non-zero exit status 1.

That is really for another PR - there is an option to disable maketx on look so you shouldn't publish renderman look with that option turned on - also there is ongoing effort to implement these renderer specific conversion tools (#2971) already and renderman owns should be implemented too

m-u-r-p-h-y

After manually switching off the maketx option on look instances in Maya the publishing works correctly.

Reapplied the looks in lighting and everything seems correct.

As mentioned already, we should redesign the renderers support to better define each renderer options, texture conversions, color management and other specifics for each individually.

m-u-r-p-h-y

successfully published looks with different prman file nodes (ptex, bump and texture)

BigRoy · 2022-05-30T13:21:38Z

openpype/hosts/maya/plugins/publish/collect_look.py

- node_path = get_file_node_path(node).lower()
-


Removing this introduced a bug where e.g. <UDIM> in the path wouldn't be recognized.

add support for PxrTexture

3484d57

antirotor added type: enhancement Enhancements to existing functionality host: Maya labels May 16, 2022

antirotor requested a review from m-u-r-p-h-y May 16, 2022 10:44

antirotor self-assigned this May 16, 2022

BigRoy reviewed May 16, 2022

View reviewed changes

list to sets and var name change

694c365

support for other renderman nodes

43f7ad5

BigRoy reviewed May 18, 2022

View reviewed changes

fix supported nodes

5ceba8c

m-u-r-p-h-y suggested changes May 18, 2022

View reviewed changes

m-u-r-p-h-y approved these changes May 19, 2022

View reviewed changes

antirotor and others added 2 commits May 20, 2022 15:22

♻️ refactored work with attributes

4c4c824

🐛 fix node attribute name

93c4e34

antirotor requested a review from m-u-r-p-h-y May 25, 2022 12:09

m-u-r-p-h-y approved these changes May 25, 2022

View reviewed changes

antirotor merged commit 76e1bc7 into develop May 25, 2022

antirotor deleted the enhancement/OP-3256_support-for-pxrtexture branch May 25, 2022 14:39

BigRoy reviewed May 30, 2022

View reviewed changes

BigRoy mentioned this pull request May 30, 2022

Maya: Fix udim support for e.g. uppercase <UDIM> tag #3266

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Looks: add basic support for Renderman #3190

Looks: add basic support for Renderman #3190

antirotor commented May 16, 2022

ynbot commented May 16, 2022

BigRoy May 16, 2022

BigRoy May 16, 2022

BigRoy May 16, 2022

m-u-r-p-h-y commented May 16, 2022 •

edited

Loading

antirotor commented May 16, 2022

m-u-r-p-h-y commented May 17, 2022

m-u-r-p-h-y commented May 17, 2022

BigRoy commented May 17, 2022

BigRoy May 18, 2022

m-u-r-p-h-y left a comment

antirotor commented May 19, 2022

m-u-r-p-h-y left a comment

m-u-r-p-h-y left a comment

BigRoy May 30, 2022

	if cmds.nodeType(node) in ['aiImage', 'PxrTexture']:
	if cmds.nodeType(node) in {'aiImage', 'PxrTexture'}:

		if cmds.nodeType(node) not in [
		"file", "aiImage", "RedshiftNormalMap", "PxrTexture"]:

Looks: add basic support for Renderman #3190

Looks: add basic support for Renderman #3190

Conversation

antirotor commented May 16, 2022

Feature

Testing:

ynbot commented May 16, 2022

BigRoy May 16, 2022

Choose a reason for hiding this comment

BigRoy May 16, 2022

Choose a reason for hiding this comment

BigRoy May 16, 2022

Choose a reason for hiding this comment

m-u-r-p-h-y commented May 16, 2022 • edited Loading

antirotor commented May 16, 2022

m-u-r-p-h-y commented May 17, 2022

m-u-r-p-h-y commented May 17, 2022

BigRoy commented May 17, 2022

BigRoy May 18, 2022

Choose a reason for hiding this comment

m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

antirotor commented May 19, 2022

m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

BigRoy May 30, 2022

Choose a reason for hiding this comment

m-u-r-p-h-y commented May 16, 2022 •

edited

Loading