Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: renderman displays needs to be filtered #3242

Merged
merged 1 commit into from
May 25, 2022

Conversation

antirotor
Copy link
Member

@antirotor antirotor commented May 24, 2022

Bug fix

This changes allows skipping processing of display type of Renderman that doesn't produce any file output. It should fix publishing renders on farm where validator was expecting produced files from those unsupported display types.

How to test

  1. Open Maya with Renderman
  2. Load / Create scene for testing rendering
  3. Create Rendering instance
  4. Configure some render channels / displays

Running this should list all your displays currently present:

from rfm2.api.displays import get_displays


displays = get_displays()["displays"]
for name, display in displays.items():
    print(f"{name}: {display['driverNode']['type']}")

you should get bunch of d_openexr (per number of displays you've created)

  1. Open Renderman IPR
  2. After it did some work, run the above code again. You should get the same number of d_openexr plus one d_it. That's expected.
  3. Now publish/submit you renders. Publishing script on farm should publish the renders.

Close #3241

don't process renderman display type that are not producing any file output (like `d_it`)
@antirotor antirotor added type: bug Something isn't working host: Maya labels May 24, 2022
@antirotor antirotor self-assigned this May 24, 2022
@ynbot
Copy link
Contributor

ynbot commented May 24, 2022

Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving the PR.

we still need to investigate strange prman behavior with IPR session creating arbitrary displays and effectively switching multipart exr off, but this PR is good to go now.

@antirotor antirotor merged commit dd6c41d into develop May 25, 2022
@antirotor antirotor deleted the bugfix/OP-3298_filter-renderman-displays branch May 25, 2022 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maya: renderman displays needs to be filtered
3 participants