Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Ftrack: Chunk sizes for queries has minimal condition #3244

Merged
merged 1 commit into from
May 26, 2022
Merged

Ftrack: Chunk sizes for queries has minimal condition #3244

merged 1 commit into from
May 26, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented May 25, 2022 •
edited
Loading

Brief description

Make sure chunk size is at least 1 when chunks are created.

Additional info

The issue happens in rare ocassions where a lot of entities from ftrack are queried at once.

Testing notes:

  1. There must be a very large project on ftrack (5000 entities at least)
  2. Run sync to avalon
  3. It should not crash

@iLLiCiTiT iLLiCiTiT self-assigned this May 25, 2022
@iLLiCiTiT iLLiCiTiT added type: bug Something isn't working module: Ftrack labels May 25, 2022
@iLLiCiTiT iLLiCiTiT requested review from 64qam and kalisp May 25, 2022 11:36
@iLLiCiTiT iLLiCiTiT merged commit 8cbd2ee into develop May 26, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/ftrack_chunks_avoid_invalid_chunk_size branch May 26, 2022 08:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kalisp kalisp kalisp approved these changes

@64qam 64qam Awaiting requested review from 64qam

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
module: Ftrack type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @kalisp