Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: Change default icon path in settings #3247

Merged
merged 2 commits into from
May 31, 2022
Merged

Nuke: Change default icon path in settings #3247

merged 2 commits into from
May 31, 2022

Conversation

ClementHector
Copy link
Contributor

Brief description

I added an icon in resource for nuke studio and modified the default paths for nukex and nukestudio.

Additional info

It's the only icon nuke studio that looks like the others nuke, if you find better I can replace it :)

@ClementHector ClementHector marked this pull request as ready for review May 25, 2022 17:18
@ClementHector ClementHector changed the title Change default nuke icon path in settings Nuke: Change default icon path in settings May 26, 2022
m-u-r-p-h-y
m-u-r-p-h-y suggested changes May 26, 2022
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind taking a closer look at all the Nuke icons once again? Each of them is different levels of black, different resolution and different graphical style

image

it is not looking good

image

thank you!

@m-u-r-p-h-y
Copy link
Member

I was looking at the nuke installation folder, and found all the icons, but only in 48px resolution :-(

plugins\icons\NukeStudioApp48.png
plugins\icons\NukeXApp48.png

Nuke is the only one with higher-res ones
plugins\icons\NukeApp256.png
plugins\icons\NukeApp128.png
plugins\icons\NukeApp64.png
plugins\icons\NukeApp48.png

would it be enough?

@ClementHector
Copy link
Contributor Author

I added the icons you provided :)

m-u-r-p-h-y
m-u-r-p-h-y approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and consistent now :)

image

thanks Clément

@antirotor antirotor merged commit 8b649e7 into ynput:develop May 31, 2022
@antirotor antirotor added type: enhancement Enhancements to existing functionality host: Nuke labels May 31, 2022
@ClementHector ClementHector deleted the add-nuke-default-icon branch June 1, 2022 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

Assignees
No one assigned
Labels
host: Nuke type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ClementHector @m-u-r-p-h-y @antirotor