This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
General: Filter representations before integration start #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| published_representations = {} | ||
| for idx, repre in enumerate(instance.data["representations"]): | ||
| for idx, repre in enumerate(repres): |
There was a problem hiding this comment.
Loop control variable 'idx' not used within the loop body. If this is intended, start the name with an underscore.
| @@ -158,7 +192,7 @@ def process(self, instance): | |||
| self.handle_destination_files(self.integrated_file_sizes, 'remove') | |||
| six.reraise(*sys.exc_info()) | |||
|
|
|||
| def register(self, instance): | |||
| def register(self, instance, repres): | |||
There was a problem hiding this comment.
'IntegrateAssetNew.register' is too complex (52)
This was referenced Jun 23, 2022
64qam
approved these changes
Jun 23, 2022
iLLiCiTiT
deleted the
bugfix/filter_representations_before_integration_start
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Representations filtering in
IntegrateAssetNewhappens as first step.Description
Representations were validated after subset and version creation and is not handled case when instance contains only representations that should not be integrated. Integration still fails if instance don't have any representations, but won't crash if none of those representations should not be integrated. Reset of
"transfers"key on instance was moved to end of representations loop instead of at the start -> make sure that transfers end up with same values after each representation process.Testing notes:
Related to testing notes in PR