Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Re-use maintained_time from lib #3460

Merged
merged 4 commits into from
Jul 5, 2022

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jul 1, 2022

Brief description

Code cleanup - re-use maintained_time from Maya lib.

plus also removed two unused lines of code.

Testing notes:

  1. Extract playblast should work like before
  2. Extract thumbnail should work like before

@@ -81,9 +79,7 @@ def process(self, instance):
if preset.pop("isolate_view", False) and instance.data.get("isolate"):
preset["isolate"] = instance.data["setMembers"]

with maintained_time():
filename = preset.get("filename", "%TEMP%")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this unused variable was also removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was copy->pasted from extract_playplast.

Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems clear to me. @antirotor can you merge if you agree?

@mkolar
Copy link
Member

mkolar commented Jul 5, 2022

I just resolved the conflict and merging

@mkolar mkolar added the type: refactor Structural changes not affecting functionality label Jul 5, 2022
@mkolar mkolar merged commit c84373f into ynput:develop Jul 5, 2022
@BigRoy BigRoy deleted the cleanup_reuse_maintained_time branch March 20, 2024 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants