Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Delete old versions is safer when ftrack is disabled #3462

Conversation

kaamaurice
Copy link
Contributor

@kaamaurice kaamaurice commented Jul 1, 2022

Brief description

The Delete Old Versions should use openpype.settings to get if ftrack module is enable and proceed ftrack logic only if needed.

Description

see issue : Delete Old Versions relies on Ftrack session - #2801

Testing:

  1. Disable Ftrack in the OpenPYPE Studio settings
  2. Use Loader tool to action Delete Old Versions

Resolves: #2801

@ynbot
Copy link
Contributor

ynbot commented Jul 1, 2022

Task linked: OP-2801 Site Sync Summary

@kaamaurice kaamaurice force-pushed the bugfix/OP-2801_delete-old-version-allways-relies-on-ftrack branch from 5af9c95 to 45cc1ed Compare July 1, 2022 14:51
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Jul 4, 2022

Good catch. There are requested few minor changes regarding this (made PR).

@iLLiCiTiT iLLiCiTiT self-requested a review July 4, 2022 09:05
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Jul 4, 2022
@iLLiCiTiT iLLiCiTiT changed the title Bugfix: delete_old_version should use studio settings to process ftrack logic. General: Delete old versions is safer when ftrack is disabled Jul 4, 2022
@kaamaurice kaamaurice removed their assignment Jul 6, 2022
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@iLLiCiTiT iLLiCiTiT merged commit 5d0108f into ynput:develop Jul 7, 2022
@kaamaurice kaamaurice deleted the bugfix/OP-2801_delete-old-version-allways-relies-on-ftrack branch July 13, 2022 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Old Versions relies on Ftrack session
3 participants