Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: thumbnail extractor fix #3474

Merged

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Jul 7, 2022

Brief description

The extractor is bypassed to ffmpeg if oiiotool is failing

Description

Oiiotool was failing on some version of CentOS that seems to not handle oiiotool correctly, so as a fallback we now use ffmpeg when oiiotool fails to do its conversion.

Dependency

@jakubjezek001 jakubjezek001 self-assigned this Jul 7, 2022
@jakubjezek001 jakubjezek001 requested review from a user and iLLiCiTiT July 7, 2022 13:51
@ynbot
Copy link
Contributor

ynbot commented Jul 7, 2022

@jakubjezek001 jakubjezek001 added the type: bug Something isn't working label Jul 7, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbnail extractor code looks good to me!

@jakubjezek001 jakubjezek001 merged commit 8162a56 into develop Jul 8, 2022
@jakubjezek001 jakubjezek001 deleted the bugfix/OP-3543_OIIO-error-on-Thumbnail-creation-v312 branch July 8, 2022 10:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants