This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
General: Better arguments order in creator init #3475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Change order of creator init arguments to have most used project settings as first to less important arguments as last.
Description
In most of cases when creator want to override initialization it's because of using project settings thus it's better to have it as first argument, then system settings and then what is probably not used in custom init just to be passed to super init.
Additional info
Breaks backwards compatibility. So this should be done now before new publisher is used in all hosts.
Order was change from most used to less used arguments.