This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Kitsu: Use query function from client #3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: OP-3404 Use query functions in kitsu |
iLLiCiTiT
added
module: Kitsu
Tilix4
suggested changes
Jul 12, 2022
Co-authored-by: Félix David <felixg.david@gmail.com>
Tilix4
suggested changes
Jul 13, 2022
Change: Asset is put under an AssetType folder
Fix: shot duplicate name using shot's hierarchy (ep, seq)
Tilix4
approved these changes
Jul 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Use query functions instead of database queries in kitsu/zou sync.
Description
Goal is to replace all mongo specific queries in code with functions that can use different source of data. At this moment we're replacing just receiving of data. In some cases the logic was slightly modified as direct queries by custom subkeys in data are not allowed at this moment. Places where it could make potential issues (even before this PR) were commented.
Additional information
Made sure that
dbconwon't change type fromAvalonMongoDBtopymongo.Collectionduring sync which could cause some issues especially with these changes.Testing notes: