Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

NewPublisher: Keep plugins with mismatch target in report #3498

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Add plugins that don't have matching targets to publish report so we have available all loaded plugins.

Description

Filtered plugins are marked as skipped so they are visible in the report view. The main reason is confusion that plugin is not visible in view and is not in crashed plugin paths.

Testing notes:

  1. Run validation in new publisher
  2. Go to report view
  3. Unhide skipped plugins
  4. You should see plugins that were skipped because if mismatched targets

@iLLiCiTiT iLLiCiTiT self-assigned this Jul 12, 2022
@iLLiCiTiT iLLiCiTiT requested a review from kalisp July 12, 2022 15:16
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Jul 12, 2022
@kalisp
Copy link
Member

kalisp commented Jul 13, 2022

Sorting looks kinda weird: (collectors in validator section)
Screenshot 2022-07-13 173215

Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting looks weird.

@iLLiCiTiT iLLiCiTiT requested a review from kalisp July 13, 2022 19:48
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@iLLiCiTiT iLLiCiTiT merged commit 8d0c694 into develop Jul 14, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/add_mismatch_target_plugins_to_report branch July 14, 2022 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants