This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
General: Event system #3499
Merged
General: Event system #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubjezek001
approved these changes
Jul 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
It is possible to create independent event systems with own callback and topics.
Description
This is small change related to current event system which works only in global scope but in some cases it would be helpful to have independent event system from global scope. For example in tools which are not based on Qt signals which is not usefull all cases especially when their controller should be Qt independent.
Additional information
For example new publisher already has it's own implementation of independent event system but it's not nice to read or maintain as most of the logic is related to handling references to callbacks. This would make the controller much cleaner.
Note
Event system is not used anywhere because this change should be properly tested before it's used so we don't break current usages.
Testing notes:
Event callbacks should work as they did.
taskChangedfrom workfiles tool should be captured in hosts (e.g. Maya or Nuke) and frame start/end should be updated to new context (and timer on ftrack should change to new context too)