Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

TrayPublisher: Simple creation enhancements and fixes #3513

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jul 14, 2022

Brief description

Simple creators can handle multiple path items and can (really) create reviews from representations.

Description

Simple creators can have "multiple item" in filepath which will cause that there is more then one representaion on the instance. Review collector was removed because there also must be a way how to mark a representation for review which is tricky with only publish plugin attributes thus review marking was moved to creator and it's related collector. For simple creators is last representation used for instance source. Simple creators also have second input for review representation.

Additional info

Moved order of collecting of cleanup keys earlier (it has none dependency and zero effect). Removed collect review family collector from tray publisher. Validation of source filepaths will crash when source filepath is set with empty list. Instance data containt data from asset which are collected in collect instance anatomy data (fps, frameStart, frameEnd, handleStart, hanleEnd) which are required for most of plugins dealing with rendering (e.g. extract review). Reset of publish view will first save changes before refresh (refresh will not cause loose of changed attributes). Last representation path is used as source for instance. Small change to be able zoom text in report view. FileDef can have defined custom extensions label.

Testing notes:

  1. Open tray publisher
  2. Create something reviewable using simple creators and mark it to be review
  3. Hit publish and review should be created
  • if filepaths are empty validator should tell you
  • publishing should crash if only review path is entered in simple creation
  • review is not created if there is no file in reviewable input

@ynbot
Copy link
Contributor

ynbot commented Jul 14, 2022

@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review July 14, 2022 13:23
@iLLiCiTiT iLLiCiTiT self-assigned this Jul 14, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Jul 14, 2022
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves my issues.
Two separate boxes for representations vs review representations are bit weird, but I understand why they are there.

@iLLiCiTiT iLLiCiTiT merged commit 1408836 into develop Jul 15, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-3578_traypublisher_file_definition_and_simple_creators branch July 15, 2022 12:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants