Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Move load related functions into pipeline #3527

Merged
merged 19 commits into from
Jul 25, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jul 15, 2022

Brief description

Loading workflow specific functions were moved to openpype.pipeline.load and their related to other places.

Description

Implemented functions to filter containers into few categories to be able get outdated containers or check for them easier. Added helper client function to find out if version id is latest version.

Functions marked as deprecated in openpype.lib are get_latest_version, is_latest and any_outdated.

Testing notes:

Submission to deadline should properly detect last version.
Check for outdated containers should work in hosts

  • Aftereffects
  • Harmony - loading should also mark outdated containers with red and latest with green color
  • Houdini
  • Maya
  • Photoshop

@ynbot
Copy link
Contributor

ynbot commented Jul 15, 2022

Task linked: OP-3593 Move load functions into pipeline

@iLLiCiTiT iLLiCiTiT self-assigned this Jul 15, 2022
@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Jul 15, 2022
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it yet but the code looks solid.

openpype/client/entities.py Outdated Show resolved Hide resolved
@iLLiCiTiT iLLiCiTiT requested a review from antirotor July 18, 2022 08:03
@m-u-r-p-h-y
Copy link
Member

tested with Maya 2022

  • submitting to deadline
  • loader
  • manager (removing items from the scene)

@64qam
Copy link
Member

64qam commented Jul 20, 2022

Validators in AE and PS are ignored

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Jul 21, 2022

Not sure if it's related to this PR but there is error happening in Harmony:

Traceback (most recent call last):
File "C:\Users\...\AppData\Local\pypeclub\openpype\openpype-v3.12.2-nightly.2\openpype\tools\sceneinventory\view.py", line 246, in 

lambda: _on_update_to_latest(items)
File "C:\Users\...\AppData\Local\pypeclub\openpype\openpype-v3.12.2-nightly.2\openpype\tools\sceneinventory\view.py", line 230, in _on_update_to_latest

update_container(item, -1)
File "C:\Users\...\AppData\Local\pypeclub\openpype\openpype-v3.12.2-nightly.2\openpype\pipeline\load\utils.py", line 439, in update_container

return loader.update(container, new_representation)
File "C:\Users\...\AppData\Local\pypeclub\openpype\openpype-v3.12.2-nightly.2\openpype\hosts\harmony\plugins\load\load_imagesequence.py", line 83, in update

node = container.get("nodes").pop()
Index ERROR 

pop from empty list

@@ -334,3 +335,16 @@ def get_current_project_asset(asset_name=None, asset_id=None, fields=None):
if not asset_name:
return None
return get_asset_by_name(project_name, asset_name, fields=fields)

def is_representation_from_latest(representation):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 2 blank lines, found 1

Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues in Harmony were solved.
AE was missing in validate_containers, added and tested.

@iLLiCiTiT iLLiCiTiT merged commit cfc11bb into develop Jul 25, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-3593_Move-load-functions-into-pipeline branch July 25, 2022 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants