This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
General: Move load related functions into pipeline #3527
Merged
iLLiCiTiT
merged 19 commits into
develop
from
feature/OP-3593_Move-load-functions-into-pipeline
Jul 25, 2022
Merged
General: Move load related functions into pipeline #3527
iLLiCiTiT
merged 19 commits into
develop
from
feature/OP-3593_Move-load-functions-into-pipeline
Jul 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere are any outdated
Task linked: OP-3593 Move load functions into pipeline |
iLLiCiTiT
added
the
type: refactor
Structural changes not affecting functionality
label
Jul 15, 2022
antirotor
reviewed
Jul 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it yet but the code looks solid.
tested with Maya 2022
|
Validators in AE and PS are ignored |
Not sure if it's related to this PR but there is error happening in Harmony:
|
@@ -334,3 +335,16 @@ def get_current_project_asset(asset_name=None, asset_id=None, fields=None): | |||
if not asset_name: | |||
return None | |||
return get_asset_by_name(project_name, asset_name, fields=fields) | |||
|
|||
def is_representation_from_latest(representation): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expected 2 blank lines, found 1
kalisp
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues in Harmony were solved.
AE was missing in validate_containers
, added and tested.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Loading workflow specific functions were moved to
openpype.pipeline.load
and their related to other places.Description
Implemented functions to filter containers into few categories to be able get outdated containers or check for them easier. Added helper client function to find out if version id is latest version.
Functions marked as deprecated in
openpype.lib
areget_latest_version
,is_latest
andany_outdated
.Testing notes:
Submission to deadline should properly detect last version.
Check for outdated containers should work in hosts