-
Notifications
You must be signed in to change notification settings - Fork 129
Nuke: publish existing frames with slate with correct range #3555
Nuke: publish existing frames with slate with correct range #3555
Conversation
collection is already without it..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/usr/local/bin/flake8", line 8, in sys.exit(main()) File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main app.run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run self._run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run self.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks self.file_checker_manager.run() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run self.run_serial() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial checker.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks self.run_ast_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks for (line_number, offset, text, check) in runner: File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run parser.visit(self.tree) File "/usr/lib/python3.8/ast.py", line 371, in visit return visitor(node) File "/usr/lib/python3.8/ast.py", line 379, in generic_visit self.visit(item) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef self.capture_issues_visitor('ClassDef', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor self.generic_visit(node) File "/usr/lib/python3.8/ast.py", line 381, in generic_visit self.visit(value) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call self.capture_issues_visitor('Call', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor issues = checker.run(node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run if isinstance(arg, ast.Call) and arg.func.id == 'locals': AttributeError: 'Attribute' object has no attribute 'id'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "farm" and "using existing frames" options with slate works with this PR.
Using local publish produces double slate in review files (EXRs are OK). Local publish works with current develop, so I assume fixed farm publish broke local publish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/usr/local/bin/flake8", line 8, in sys.exit(main()) File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main app.run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run self._run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run self.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks self.file_checker_manager.run() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run self.run_serial() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial checker.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks self.run_ast_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks for (line_number, offset, text, check) in runner: File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run parser.visit(self.tree) File "/usr/lib/python3.8/ast.py", line 371, in visit return visitor(node) File "/usr/lib/python3.8/ast.py", line 379, in generic_visit self.visit(item) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef self.capture_issues_visitor('ClassDef', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor self.generic_visit(node) File "/usr/lib/python3.8/ast.py", line 381, in generic_visit self.visit(value) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call self.capture_issues_visitor('Call', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor issues = checker.run(node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run if isinstance(arg, ast.Call) and arg.func.id == 'locals': AttributeError: 'Attribute' object has no attribute 'id'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/usr/local/bin/flake8", line 8, in sys.exit(main()) File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main app.run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run self._run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run self.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks self.file_checker_manager.run() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run self.run_serial() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial checker.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks self.run_ast_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks for (line_number, offset, text, check) in runner: File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run parser.visit(self.tree) File "/usr/lib/python3.8/ast.py", line 371, in visit return visitor(node) File "/usr/lib/python3.8/ast.py", line 379, in generic_visit self.visit(item) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef self.capture_issues_visitor('ClassDef', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor self.generic_visit(node) File "/usr/lib/python3.8/ast.py", line 381, in generic_visit self.visit(value) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call self.capture_issues_visitor('Call', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor issues = checker.run(node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run if isinstance(arg, ast.Call) and arg.func.id == 'locals': AttributeError: 'Attribute' object has no attribute 'id'
Thanks for catching this! Please try it again now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…rames-frame-shorter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/usr/local/bin/flake8", line 8, in sys.exit(main()) File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main app.run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run self._run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run self.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks self.file_checker_manager.run() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run self.run_serial() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial checker.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks self.run_ast_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks for (line_number, offset, text, check) in runner: File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run parser.visit(self.tree) File "/usr/lib/python3.8/ast.py", line 371, in visit return visitor(node) File "/usr/lib/python3.8/ast.py", line 379, in generic_visit self.visit(item) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef self.capture_issues_visitor('ClassDef', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor self.generic_visit(node) File "/usr/lib/python3.8/ast.py", line 381, in generic_visit self.visit(value) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call self.capture_issues_visitor('Call', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor issues = checker.run(node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run if isinstance(arg, ast.Call) and arg.func.id == 'locals': AttributeError: 'Attribute' object has no attribute 'id'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I exclude Integrate Asset for Nuke host and render + write Families, publishing works fine for local and farm publish, with clean or "dirty" work folder.
I tested h264 and MXF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/usr/local/bin/flake8", line 8, in sys.exit(main()) File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main app.run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run self._run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run self.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks self.file_checker_manager.run() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run self.run_serial() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial checker.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks self.run_ast_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks for (line_number, offset, text, check) in runner: File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run parser.visit(self.tree) File "/usr/lib/python3.8/ast.py", line 371, in visit return visitor(node) File "/usr/lib/python3.8/ast.py", line 379, in generic_visit self.visit(item) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef self.capture_issues_visitor('ClassDef', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor self.generic_visit(node) File "/usr/lib/python3.8/ast.py", line 381, in generic_visit self.visit(value) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call self.capture_issues_visitor('Call', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor issues = checker.run(node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run if isinstance(arg, ast.Call) and arg.func.id == 'locals': AttributeError: 'Attribute' object has no attribute 'id'
@jrsndl please try it one more time. I found some flaws in Farm and Local publishing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brief description
Range is correct when published slate from existing frames
Description
The miscalculation was removed.
Testing notes: