Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

NewPublisher: Python 2 compatible html escape #3559

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jul 25, 2022

Brief description

Escape of html syntax symbols is implemented in openpype instead of using Python 3 module.

Description

We've used Python 3 module html for escaping of html symbols which is not available in Python 2 hosts. Thus we needed to add that option for them too. The basic escaping is easy to implement and does not need special python module for that so a function was added.

Testing notes:

  1. Open NewPublisher in host with Python 2
  2. UI should show their labels and not crash

Resolves #3558

@iLLiCiTiT iLLiCiTiT self-assigned this Jul 25, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Jul 25, 2022
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the issue in Maya

@iLLiCiTiT iLLiCiTiT merged commit 14ba4d3 into develop Jul 26, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/python_2_compatible_html_escape branch July 26, 2022 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewPublisher: Python 2 compatible html escape
2 participants