Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Fix animated attributes (ie. overscan) on loaded cameras breaking review publishing. #3562

Merged
merged 4 commits into from
Jul 26, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 25, 2022

Brief description

Fixes #2807 by checking for locked attributes and skipping them.

Description

Issue #2807 stems from published cameras being unable to distinguish animated attributes on them when they're published as alembics, so when they're loaded in again, the attributes are automatically connected to the alembic nodes. This solves that issue by testing if the attribute is locked and passes changing those attributes if they're connected.

Additional info

It's mainly handled in capture.py, with the soft fail wrapper by @kalisp included in case Maya acts up.

Testing notes:

  1. In Maya, animate attribute on a created camera shape.
  2. Create camera instance.
  3. Publish camera instance.
  4. Load published camera in as alembic.
  5. Create review instance from published camera.

Should run smoothly as opposed to breaking during the extract playblast stage.

@ghost ghost added type: bug Something isn't working host: Maya labels Jul 25, 2022
@ghost ghost requested review from mkolar and antirotor July 25, 2022 12:43
@ghost ghost self-assigned this Jul 25, 2022
@ynbot
Copy link
Contributor

ynbot commented Jul 25, 2022

Task linked: OP-3363 Camera Overscan Attribute

@ghost ghost requested review from m-u-r-p-h-y and removed request for mkolar July 25, 2022 12:49
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working seamlessly

Maya2022.4

  • animated focal length
  • published and used for review
  • everything went smoothly, playblast was created and published to ftrack

image

@mkolar mkolar merged commit cc39f44 into develop Jul 26, 2022
@mkolar mkolar deleted the OP-3363_Camera-Overscan-Attribute branch July 26, 2022 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maya: Camera Overscan Attribute
3 participants