This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Ftrack: Handle missing published path in integrator #3570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Ftrack integrator can handle if
published_path
is not filled on representation.Description
Ftrack integrator expected that
published_path
is always filled on representation for review and thumbnail upload, but in some very specifici cases they may not be integrated withIntegrateAsset
thus they don't have filled the key at all. But in that cases can be used their source path.Before this PR it crashed with
KeyError
.Traceback
Testing notes:
Not sure how it is possible to make reviewable that is not integrated to validate it won't crash.