Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Separate extraction of template data into more functions #3574

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jul 26, 2022

Brief description

Separated get_workdir_data into smaller functions and moved them into openpype.pipeline.

Description

Created new file ./openpype/pipeline/template_data.py which contains functions related to template data preparation. Function get_workdir_data was split into get_general_template_data, get_project_template_data, get_asset_template_data and get_task_template_data. All of them are covered with universal get_template_data or get_template_data_with_names which are calling the teparated functions based on passed arguments.

Functions get_workdir_data and get_system_general_anatomy_data were marked as deprecated and their usages were replaced with new functions.

Additional information

Added Deprecated category into docstrings of deprecated functions telling when will be removed.

Testing notes:

  • Application should be launched and should be able to use last workfile as before
  • TVPaint load workfile
  • Nuke create write node should use right template for output path (and fill it to write node)
  • Unreal prelaunch hook for workfile should work as did
  • Ftrack action to fill workfile attribute should work as before
  • Collect anatomy template data should be filled correctly
  • Workfiles tool - Save As dialog should work

@ynbot
Copy link
Contributor

ynbot commented Jul 26, 2022

@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Jul 26, 2022
@iLLiCiTiT iLLiCiTiT self-assigned this Jul 26, 2022
@iLLiCiTiT iLLiCiTiT merged commit ee374b1 into develop Jul 28, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-3647_Separate-extraction-of-template-data-into-more-functions branch July 28, 2022 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants