Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Ftrack: Add more metadata to ftrack components #3612

Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Aug 3, 2022

Brief description

Add more metadata to ftrack components even for those which are not for review.

Description

Add fps, width, height to components that can potentially be able to use it in CineCync. To achieve that I'm using ffprobe to read information about published path. If ffprobe crashes the component won't have any metadata otherwise fps (or frameRate is added.

Fixed issue when there are both ftrackreview-mp4 and ftrackreview-image which could cause the thumbnail is showed in play instead of video. When both are available the ftrackreview-image is renamed to thumbnail.

Additional information

We have no information about representation, is it an image or video with width, height and fps and sometimes when the information is there it is sometimes copied from source representation which changed so the data are not relevant.

Testing notes:

  1. Publish something that produces reviewable and create source filepath components in ftrack
  2. Check all created components in ftrack, they should have metadata about frameRate, width and height (workfile probably won't)

@ynbot
Copy link
Contributor

ynbot commented Aug 3, 2022

@iLLiCiTiT iLLiCiTiT self-assigned this Aug 3, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Aug 3, 2022
@iLLiCiTiT iLLiCiTiT merged commit e19f0ba into develop Aug 3, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-3703_fps-ftrack-metadata-for-cineSyncPlay branch August 3, 2022 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants