This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
General: Plugin settings handled by plugins #3623
Merged
+276
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: OP-3679 Plugin settings handled by plugins |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| print(">>> We have preset for {}".format(plugin_name)) | ||
| for option, value in plugin_settings.items(): | ||
| if option == "enabled" and value is False: | ||
| setattr(cls, "active", False) |
There was a problem hiding this comment.
Do not call setattr with a constant attribute value, it is not any safer than normal property access.
| print(">>> We have preset for {}".format(plugin_name)) | ||
| for option, value in plugin_settings.items(): | ||
| if option == "enabled" and value is False: | ||
| setattr(cls, "active", False) |
There was a problem hiding this comment.
Do not call setattr with a constant attribute value, it is not any safer than normal property access.
64qam
approved these changes
Aug 5, 2022
iLLiCiTiT
deleted the
feature/OP-3679_Plugin-settings-handled-by-plugins
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Loader and creator settings are handled by plugins.
Description
LoaderPluginandLegacyCreatorhave new classmethodapply_settingswhich by default contains logic fromopenpype.lib.set_plugin_attributes_from_settings.Function
filter_pyblish_pluginswhich apply settings for pyblish plugins was moved toopenpype.pipeline.publish.lib. For pyblish plugins was added ability to implement classmethoddef apply_settings(cls, project_settings, system_settings)too. Can customize how settings are applied on a plugin. This is optional. If method is not implemented the "automated" approach is used as before - this option was added to be able handle some cases when path location of plugin does not exactly match settings path. Functions in lib were marked as deprecated.Testing notes:
E.g. in Maya, Nuke, ...