Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

TimersManager: Plugins are in timers manager module #3639

Merged

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Moved timers manager plugins into the module and mark public functions as deprecated.

Description

Moved start timer and stop timer publish plugins into timer manager. Marked change_timer_to_current_context function in openpype lib as deprecated.

Testing notes:

Stop/Start timer plugins should work (stop is extractor, start is integrator).

  • they must be enabled in system settings of timers manager module modules/timers_manager/disregard_publishing

@ynbot
Copy link
Contributor

ynbot commented Aug 9, 2022

@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Aug 9, 2022
@iLLiCiTiT iLLiCiTiT self-assigned this Aug 9, 2022
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work (tested in AE).

@iLLiCiTiT iLLiCiTiT merged commit 0c277f0 into develop Aug 12, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-3717_Move-timers-manager-logic-to-timers-manager branch August 12, 2022 10:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants