Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Optimized OCIO configs #3650

Merged
merged 6 commits into from
Aug 16, 2022

Conversation

antirotor
Copy link
Member

Description

OCIO configs vendorized as git submodule had a huge size, adding almost 3Gb to OpenPype. This is changing it to use reduced OCIO configs managed by Poetry.

Testing

This should build correctly and that darn maketx color space issue in Maya should be still fixed.

🔧 This will go to 3.14 release

@antirotor antirotor added type: enhancement Enhancements to existing functionality Bump Minor Pull requests that update a dependency file labels Aug 11, 2022
@antirotor antirotor requested review from m-u-r-p-h-y, iLLiCiTiT and a user August 11, 2022 16:14
@antirotor antirotor self-assigned this Aug 11, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, will test it first thing tomorrow!

@antirotor
Copy link
Member Author

So Github has bandwidth limit on Git with LFS, so this is not option. We need to reimplement this to serve it as a zip file the same way as we are now doing with ffmpeg/oiio.

@antirotor antirotor marked this pull request as ready for review August 12, 2022 16:44
poetry.lock Show resolved Hide resolved
@ghost
Copy link

ghost commented Aug 15, 2022

What do I need to do to test this out? Just normally pull in and publish a look?

@iLLiCiTiT
Copy link
Member

You should run ~/openpype/tools/create_env script to update third party libs.

@ghost
Copy link

ghost commented Aug 15, 2022

Thank you Kuba, this currently fails because the path evaluates to C:\Users\Dumbledoor\Documents\Code\OpenPype\vendor\bin\ocioconfigOpenColorIOConfigs\nuke-default\config.ocio which doesn't seem to exist.

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@antirotor antirotor requested a review from a user August 15, 2022 15:38
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works!

@antirotor antirotor merged commit 5420288 into release/3.14.x Aug 16, 2022
@antirotor antirotor deleted the feature/optimize-ocio-configs branch August 16, 2022 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bump Minor Pull requests that update a dependency file type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants