Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Scene Inventory: Add subsetGroup column #3658

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Aug 12, 2022

Brief description

This adds a subsetGroup column to the Scene Inventory / Manager.

Description

We tend to group publishes in the Loader (shortcut: ctrl + g) to sometimes label things as "extras" or even group them to be "deprecated".
By showing the column in the Manager this is now also much easier to trace to that information.

afbeelding

Additional info

Code might be a bit messy - so please double check.

The "icon" for the group is the default group icon. Originally in Avalon groups could be configured on the project to allow custom icons per groups, etc. but that's currently not supported in OpenPype as far as I know. Thus I had chosen for now to just hardcode the icon.

This would be extra useful as soon as better UX for filtering is added to tools - then we could also filter by subset group, etc.

Testing notes:

  1. Load some content with and without subset groups.
  2. Check the scene inventory

@@ -88,7 +88,8 @@ def __init__(self, parent=None):
view.setColumnWidth(1, 55) # version
view.setColumnWidth(2, 55) # count
view.setColumnWidth(3, 150) # family
view.setColumnWidth(4, 100) # namespace
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: Namespace column didn't exist - this was actually setting the loader column. I felt the default width for the loader column was slightly too small and most loader names got cut off. So I've set the loader column width to 150.

@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Aug 17, 2022
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok and works. Can someone check it from UX perspective ( @mkolar @antirotor )?

Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally just name it Group rather than subsetGroup.

In general It's a good idea, however it's becoming painfully obvious that we'll need to implement hiding and unhiding of columns. For example most of clients on support don't actually use this grouping that much and for those it's suddenly and empty column that's there all the time and is never really populated. Hence needless confusion.

That's more food for though though and I'm happy with merging this.

Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please tweak the name of the column, then we can merge

openpype/tools/sceneinventory/model.py Outdated Show resolved Hide resolved
openpype/tools/sceneinventory/model.py Outdated Show resolved Hide resolved
openpype/tools/sceneinventory/model.py Outdated Show resolved Hide resolved
@BigRoy
Copy link
Collaborator Author

BigRoy commented Aug 18, 2022

@mkolar How about solely updating the header column's name but keeping it the same in the code? :) Somehow I feel subsetGroup keeps it linked to the original data attribute name and describes what it is exactly. Or do you feel group is clear enough and one should now that these relate to the subset instead of the version or representation?

I'm fine either way.

EDIT: Actually - let's just do as you say. We can always clarify if code becomes unclear at some point.

Co-authored-by: Milan Kolar <mkolar@users.noreply.github.com>
@BigRoy BigRoy requested a review from mkolar August 18, 2022 09:45
@iLLiCiTiT
Copy link
Member

@mkolar are you ok with current state?

@iLLiCiTiT iLLiCiTiT merged commit a7a65aa into ynput:develop Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants