Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Blender: validators code correction with settings and defaults #3662

Merged
merged 8 commits into from
Aug 30, 2022
Merged

Blender: validators code correction with settings and defaults #3662

merged 8 commits into from
Aug 30, 2022

Conversation

kaamaurice
Copy link
Contributor

Brief description

Blender Validators for publishing check with more conditions and are setupable with Project Settings.

Description

  • Validators check instance members for correct object type.
  • Settings and defaults for OP project settings added to control validators for publishing.
  • category, order, logger messages rectified.

BigRoy
BigRoy reviewed Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Sorry for commenting some things that aren't directly related to your code changes. I've commented some things that stood out to me. (Note that I don't use Blender so please take them with a grain of salt if I'm saying stupid things!)

openpype/hosts/blender/plugins/publish/validate_camera_zero_keyframe.py Outdated Show resolved Hide resolved
openpype/hosts/blender/plugins/publish/validate_mesh_has_uv.py Outdated Show resolved Hide resolved
openpype/hosts/blender/plugins/publish/validate_mesh_has_uv.py Outdated Show resolved Hide resolved
openpype/hosts/blender/plugins/publish/validate_mesh_has_uv.py Outdated Show resolved Hide resolved
openpype/hosts/blender/plugins/publish/validate_mesh_no_negative_scale.py Outdated Show resolved Hide resolved
openpype/hosts/blender/plugins/publish/validate_no_colons_in_name.py Show resolved Hide resolved
openpype/hosts/blender/plugins/publish/validate_object_mode.py Outdated Show resolved Hide resolved
@jakubjezek001 jakubjezek001 added host: Blender type: feature Larger, user affecting changes and completely new things labels Aug 25, 2022
@iLLiCiTiT iLLiCiTiT requested review from simonebarbieri, a user and antirotor August 26, 2022 08:27
@iLLiCiTiT iLLiCiTiT merged commit ce303d2 into ynput:develop Aug 30, 2022
@Tilix4 Tilix4 mentioned this pull request Aug 31, 2022
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BigRoy BigRoy BigRoy left review comments

@mkolar mkolar mkolar left review comments

@simonebarbieri simonebarbieri simonebarbieri approved these changes

@antirotor antirotor Awaiting requested review from antirotor

Assignees
No one assigned
Labels
host: Blender type: feature Larger, user affecting changes and completely new things
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kaamaurice @simonebarbieri @BigRoy @mkolar @jakubjezek001 @iLLiCiTiT