This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Maya: containerise
dont skip empty values
#3674
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Maya host
containerise
was the only implementation that skipped imprinting values if the value was empty/None/zero (if not value
). Instead of ever allowing to do so this now forces the required attributes to actually be generated on containerise.Since all values should be string anyway I've also simplifies the logic that adds and sets the attributes.
Additional info
I was investigating an issue where some loaded containers were missing
loader
andrepresentation
attributes and I'm unsure how that happened. However, this part of the code could have potentially done so without warnings/errors ifloader
orrepresentation
values were ever considered null.Testing notes: