Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: containerise dont skip empty values #3674

Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Aug 16, 2022

Brief description

Maya host containerise was the only implementation that skipped imprinting values if the value was empty/None/zero (if not value). Instead of ever allowing to do so this now forces the required attributes to actually be generated on containerise.

Since all values should be string anyway I've also simplifies the logic that adds and sets the attributes.

Additional info

I was investigating an issue where some loaded containers were missing loader and representation attributes and I'm unsure how that happened. However, this part of the code could have potentially done so without warnings/errors if loader or representation values were ever considered null.

Testing notes:

  1. Load containers into Maya
  2. Everything should load as usual and be visible in the Scene Inventory, etc.

@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Aug 16, 2022
BigRoy and others added 2 commits August 16, 2022 12:33
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works...

@antirotor antirotor merged commit 36fb10c into ynput:develop Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants