Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Ftrack: Store ftrack entities on hierarchy integration to instances #3677

Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Aug 16, 2022

Brief description

Ftrack integrate hierarchy is storing the created entities to instances with created task entities.

Description

Created entities during integrate hierarchy are stored to instances that should have stored those entities. Key "ftrackEntity" was already set (more then once) but "ftrackTask" was not.

Removed settings in ftrack server event handlers for first_version_status (Set status on first created version) which is not used anywhere.

Additional information

This is minor change which probably won't have much affect as it is handled only during editorial publishing which probably won't create asset versions at the time.

Testing notes:

  1. Publish editorial which create new entities in ftrack
  2. Rest of publishing should not crash
  3. If there are reviewables for new created entities they should be also added to related tasks

@ynbot
Copy link
Contributor

ynbot commented Aug 16, 2022

@iLLiCiTiT iLLiCiTiT self-assigned this Aug 16, 2022
@iLLiCiTiT iLLiCiTiT added type: enhancement Enhancements to existing functionality module: Ftrack labels Aug 16, 2022
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with traypublisher on editorial and worked as expected

@iLLiCiTiT iLLiCiTiT merged commit 7a1d161 into develop Aug 24, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-3733_Ftrack-set-version-status-on-integration branch August 24, 2022 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: Ftrack type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants