Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Webpublisher:change create flatten image into tri state #3678

Merged

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Aug 16, 2022

Brief description

CollectColorCodedInstances allows publish only flattened subset of 'image' family.

Description

Previously it was possible to set in Settings to create flatten subset of 'image' family from published subsets. But separate layers marked by publishable colors were published also.
This PR brings more granularity, now it is possible to:

  • create flattened 'image' subset of all publishable layers + create 'image' subset per publishable layer
  • create ONLY flattened 'image' subset of all publishable layers
  • not create flattened 'image' subset at all, only separate subsets per marked layer.

Documentation (add "type: documentation" label)

feature_documentation

Testing notes:

  1. set project_settings/photoshop/publish/CollectColorCodedInstances/flatten_subset_template

Screenshot 2022-08-16 170951

  1. mark some top layers in PS to be published
  2. check that only flatten subset was produced

Customer wants to have more granularity, they want to create flatten 'image', but not separate 'image' per layer.
Customer wants to have more granularity, they want to create flatten 'image', but not separate 'image' per layer.
@ynbot
Copy link
Contributor

ynbot commented Aug 16, 2022

@kalisp kalisp self-assigned this Aug 16, 2022
Resulted in failure in integrate
@kalisp kalisp changed the title Enhancement/op 3713 change create flatten image into tri state Webpublisher:change create flatten image into tri state Aug 16, 2022
@kalisp kalisp requested a review from 64qam August 16, 2022 15:10
@kalisp kalisp added sponsored Client endorsed or requested type: feature Larger, user affecting changes and completely new things labels Aug 16, 2022
@kalisp kalisp marked this pull request as ready for review August 16, 2022 15:42
@kalisp kalisp requested a review from iLLiCiTiT August 17, 2022 09:16
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, but can't test it without Photoshop.

@kalisp kalisp merged commit 37ebb16 into develop Aug 26, 2022
@kalisp kalisp deleted the enhancement/OP-3713_Change-Create-flatten-image-into-tri-state branch August 26, 2022 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
sponsored Client endorsed or requested type: feature Larger, user affecting changes and completely new things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants