This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
General: Switch from hero version to versioned works #3691
Merged
+78
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
requested review from
jakubjezek001,
kalisp,
m-u-r-p-h-y and
simonebarbieri
simonebarbieri
approved these changes
Aug 18, 2022
iLLiCiTiT
deleted the
bugfix/OP-3752_Cannot-switch-asset-from-hero-version-to-versioned
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Fix switch from hero version functionaly in scene manager tool.
Description
Bug was not related to scene manager tool but to client function
get_representation_parentswhere were not handled hero versions thus it didn't find parents and crashed.Side fixes related to loading of hero version in loader and in nuke's LoadClip. If loader crashed on loading of hero version it caused another crash when tried to show message with error becaue hero versions don't have name key in it. LoadClip crashed from same reason when added to scene "information" data.
Testing notes:
Resolves #3689