Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Hiero: Define hiero as module #3717

Merged
merged 3 commits into from
Aug 24, 2022
Merged

Hiero: Define hiero as module #3717

merged 3 commits into from
Aug 24, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Aug 24, 2022 •
edited
Loading

Brief description

Hiero is defined as OpenPype module and fix protobuf issue.

Description

Added HieroModule for hiero host which cares about handling hiero host related code. Also was added protobuf 3.20.1 into hiero vendor. That's because we override hiero's inner site-packages with ours where we have protobuf 4.21.5 which breaks hiero on start (issue for Hiero/Nukestudio 13.*).

Additional information

The protobuf issue should be maybe fixed by changing version in pyproject.toml but that would require new build. Question is if this is bad solution or not.

Testing notes:

  1. Hiero launch should work
  2. Last workfile should be opened if is available and feature is enabled
  3. Hiero and NukeStudio 13.0 and higher should not crash

Resolves #3715

@ynbot
Copy link
Contributor

ynbot commented Aug 24, 2022

Task linked: OP-3775 Hiero as module

@iLLiCiTiT iLLiCiTiT self-assigned this Aug 24, 2022
@iLLiCiTiT iLLiCiTiT merged commit ab9ed37 into develop Aug 24, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-3775_Hiero-as-module branch August 24, 2022 09:51
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with Nuke 13.2.v3, Hiero 13.2.v3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@64qam 64qam 64qam approved these changes

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

@kalisp kalisp Awaiting requested review from kalisp

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
host: Hiero
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hiero: protobuf TypeError
4 participants
@iLLiCiTiT @ynbot @m-u-r-p-h-y @64qam