Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Replace PypeLogger with Logger #3725

Merged
merged 7 commits into from
Aug 25, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Aug 24, 2022

Brief description

Code cleanup related to OpenPype logger.

Description

Class PypeLogger should not be used anymore, is marked as deprecated and logs out warning message when get_logger is called. It's usage was replaced with Logger. Also was removed calling of the class which is not needed. In some cases was logger object moved into objects from global scope.

Most changes that could cause issues happened in sync server.

Testing notes:

  1. Logging should work as expected
  2. SyncServer sync should work

Resolves #3581

@ynbot
Copy link
Contributor

ynbot commented Aug 24, 2022

Task linked: OP-3655 Replace 'PypeLogger' with 'Logger'

@iLLiCiTiT iLLiCiTiT self-assigned this Aug 24, 2022
@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Aug 24, 2022
@iLLiCiTiT iLLiCiTiT requested review from kalisp and 64qam August 24, 2022 15:07
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Site Sync works, Adobe, Maya seems to work.
Was clicking around, couldn't find an issue.
Didn't test Deadline publishing though!

@iLLiCiTiT iLLiCiTiT merged commit 1c931a1 into develop Aug 25, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-3655_Replace-PypeLogger-with-Logger branch August 25, 2022 11:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace 'PypeLogger' with 'Logger'
3 participants