Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Webpublisher: Webpublisher is used as addon #3740

Merged
merged 17 commits into from
Aug 26, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Aug 25, 2022

Brief description

Webpublished is defined as addon which gave him ability to have own cli functionality.

Description

Implementer WebpublisherAddon, it's main purpose is to give ability to define cli commands. Cli commands from global commands were "duplicated" into addon:

  • remotepublish -> module webpublisher publish
  • remotepublishfromapp -> module webpublisher publishfromapp
  • webpublisherwebserver ->module webpublisher webserver
    All of them should do the same job so they're backwards compatible. Webservice commands were modified to follow new arguments.

Moved webpublisher specific lib function from openpype.lib into webpublisher itself. The original "remote publish" function was moved into openpype.pipeline.publish.lib and renamed to remote_publish.

Webpublisher has implemented Host class WebpublisherHost to be installed.

Testing notes:

  • Webserver can be launched and is processing jobs
    • with both openpype module webpublisher webserver and legacy openpype webpublisherwebserver
  • Photoshop publishing launch photoshop, log properly and finish job as expected
  • TVPaint publishing log properly and finish job as expected
  • Other publishing starts and finish job as expected

@ynbot
Copy link
Contributor

ynbot commented Aug 25, 2022

Task linked: OP-3793 Webpublisher as addon

@iLLiCiTiT iLLiCiTiT requested review from kalisp and 64qam August 25, 2022 16:28
@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Aug 25, 2022
@iLLiCiTiT iLLiCiTiT self-assigned this Aug 25, 2022
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using "farm processing" it fails for PS:

Traceback (most recent call last):
  File "start.py", line 1151, in boot
  File "c:\Users\pypeclub\code\OpenPype\build\exe.win-amd64-3.7\dependencies\click\core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "c:\Users\pypeclub\code\OpenPype\build\exe.win-amd64-3.7\dependencies\click\core.py", line 782, in main
    rv = self.invoke(ctx)
  File "c:\Users\pypeclub\code\OpenPype\build\exe.win-amd64-3.7\dependencies\click\core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "c:\Users\pypeclub\code\OpenPype\build\exe.win-amd64-3.7\dependencies\click\core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "c:\Users\pypeclub\code\OpenPype\build\exe.win-amd64-3.7\dependencies\click\core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "c:\Users\pypeclub\code\OpenPype\build\exe.win-amd64-3.7\dependencies\click\core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "c:\Users\pypeclub\code\OpenPype\build\exe.win-amd64-3.7\dependencies\click\core.py", line 610, in invoke
    return callback(*args, **kwargs)
TypeError: publishfromapp() got an unexpected keyword argument 'host'``` 

@iLLiCiTiT
Copy link
Member Author

When using "farm processing" it fails for PS:

Please try again.

@iLLiCiTiT iLLiCiTiT merged commit 41689a3 into develop Aug 26, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-3793_Webpublisher-as-addon branch August 26, 2022 08:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants