General: Fix links query on hero version #3900
Conversation
|
Right mouse click on representation of Hero version in bottom right in Loader throws this: |
| # Links are not stored to hero versions at this moment so filter | ||
| # is limited to just versions | ||
| "type": "version" |
There was a problem hiding this comment.
Actually - are we sure? The input link collection I believe is retrieved from containers in the scene - those I suspect would have the representation id of the hero version. As such by doing this "fix" we'd never be able to list those inputs even though they are stored?
There was a problem hiding this comment.
Links are added only to versioned version documents and hero version document don't have "data" at all.
But because hero versions are based on versioned documents we can reuse links from there.
There was a problem hiding this comment.
Yes. Getting inputs FROM the hero version is then fixed. But any hero version IN the inputs is not? That hero version's inputs are not collected? (But might not be relevant for the UI we have now since it only shows direct inputs instead of a further depth.)
That does raise the question too that when we collect the inputs on publish would we want to resolve the hero version to the exact version it actually was at the time or do we want to just keep the link to the hero version? If we'd 'bake' it down to the exact version on collecting inputs the issue I mentioned would be gone plus you get the benefit of actually being able to see what version was used at the time in input link. Maybe we could tag it extra as "hero" so that the does know it originally was a hero link but at the time of publishing that was referring to v038.
@mkolar thoughts?
There was a problem hiding this comment.
Should we spin this up as a new issue?
|
Hi, is there anything to do for helping this fix to land? |
Brief description
Fixed function to find links which crashed on hero versions.
Description
Don't lookup for hero versions in
get_linked_representation_idbecause they don't have links. Made safer access to"data"key on found items to avoid possible crashes on items without links.EDITED: Added query of hero version to use standard version to which is pointing.
Testing notes: