Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: remove invalid prefix token for non-multipart outputs #3981

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

antirotor
Copy link
Member

Fix

This is fixing image prefixes for Vray and Redshift to not add <aov> token for outputs that are multipart (merged aovs).

Testing

Submit render to Deadline with merged AOVs from vray or redshift.

Close #3956

@ynbot
Copy link
Contributor

ynbot commented Oct 13, 2022

Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with m2023.2 and redshift 3.5.09

with multipart exr enabled it still sets _<aov> token for the output image

image

@m-u-r-p-h-y m-u-r-p-h-y added the type: bug Something isn't working label Oct 14, 2022
@LiborBatek
Copy link
Member

LiborBatek commented Oct 17, 2022

Just tested it in with #3954 branch and it works normally (fixes it)....giving it just <name>.####.exr not any <AOV> tokens in the filename when using multichannel exr format.

Im just not sure if these PRs should be joined together or?

@BigRoy
Copy link
Collaborator

BigRoy commented Oct 17, 2022

Im just not sure if these PRs should be joined together or?

They should, yes.

This one fixes what the expected output is for the renderer in the situations where multipart EXR is enabled.
The other fixes what is passed to Deadline in the case multipart EXR is disabled.

…bugfix/OP-4208_invalid-prefix-in-multipart-exrs
@antirotor
Copy link
Member Author

I've merged it together. One PR to rule them all.

@m-u-r-p-h-y
Copy link
Member

Redshift has actually two multipart options, not very well documented and making the whole thing a true nightmare

image

redshiftOptions.exrForceMultilayer
redshiftOptions.exrMultipart

It seems we only take into account the first one, which is the only way as with all other combinations multipart + individual aov output settings it is nearly impossible to control.

Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to go, In case of specific combinations of multipart option and per aov image tokens, user can always fall back with disabling the validator as it is really difficult to account for all possible combinations,

@antirotor antirotor merged commit 41e7382 into develop Oct 19, 2022
@antirotor antirotor deleted the bugfix/OP-4208_invalid-prefix-in-multipart-exrs branch October 19, 2022 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maya: vray/redshift multichannel exr image output prefix
5 participants