This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Publisher: Multiselection in card view #3993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/OP-4239_Multiselection-in-card-view
|
Task linked: OP-4239 Multiselection in card view |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| self._explicitly_selected_groups.append(group_name) | ||
| new_widget.set_selected(True) | ||
|
|
||
| def _select_item_extend_to(self, instance_id, group_name, new_widget): |
There was a problem hiding this comment.
'InstanceCardView._select_item_extend_to' is too complex (35)
iLLiCiTiT
requested review from
antirotor,
BigRoy,
jakubjezek001,
kalisp,
m-u-r-p-h-y and
mkolar
…re/OP-4239_Multiselection-in-card-view
…re/OP-4239_Multiselection-in-card-view
antirotor
approved these changes
Oct 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Card view now supports multiselection of items.
Description
Card view have multiselection and selectetion between views is consistent (or should be). Card view support Control + click to add/remove selection of single item and Shift+click to add selection from last selected to just selected item.
Screenshot
Testing notes:
Depends on #3972