This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Publisher: Catch creator errors #4015
Merged
+600
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: OP-4183 Crashed save cause crash of UI |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
iLLiCiTiT
added
type: bug
antirotor
approved these changes
Oct 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Handle failed operations of creator plugins in Publihser UI to safe-guard failed state.
Description
If creator failed during one of their operations the UI could stuck without any way how to rollback and user have no idea that something went wrong. For this purposes all oprations on create context raise special exceptions. Exception hold information about each failed creator with error message and optionally traceback. This can be showed in UI as a dialog. The dialog shows a tabs per each creator which failed. Exceptions are handled on collect, update, remove and create. Create widget does not handle exceptions on it's own because it would not be possible in remotelly controllerd UI instead a controller trigger events when dialog should be shown.
Reset of controller does not trigger save automatically. That is to prevent unwanted trigger e.g. when window is reopened, the previous state should not be saved because was already saved and the context could change meanwhile.
Fixed few smaller bugs. Tab
Detailscrashed if was selected before publishing started. Animations were not working in older Qt bindings.Additional info
There is one remaining issue. We don't handle change of context/workfile in hosts. We should add that option in future.
The messages are really simple right now we could change them to something understandable by both users and developers. The raised error message should maybe contain information about all creators. Also the error dialog does not have title because it looked wierd above the tabs, could be added by changing the background of the title widget to same color as tabs have in empty space.
Screenshots
Testing notes: