Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Hiero: loading effect family to timeline #4055

Merged
merged 27 commits into from
Nov 21, 2022

Conversation

jakubjezek001
Copy link
Member

Brief description

Loader for loading effects to timeline

Description

Hiero is having available loader for multi loading of effects to active timeline

Additional info

  • also fix of multiselected loading

Testing notes:

  1. open vfx testing project
  2. open loader at any active timeline
  3. select effect subset in multiselected assets
  4. chose load effect and see all effects were loaded

@jakubjezek001 jakubjezek001 self-assigned this Nov 1, 2022
@ynbot
Copy link
Contributor

ynbot commented Nov 1, 2022

Task linked: OP-4201 Load effectPlates from Hiero

@jakubjezek001 jakubjezek001 added host: Hiero type: feature Larger, user affecting changes and completely new things labels Nov 1, 2022
@github-actions github-actions bot added this to the next-patch milestone Nov 1, 2022
Copy link
Collaborator

@jrsndl jrsndl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described for "look" effects. Multiselection works.

Note that loading fails on animated transforms.

Traceback (most recent call last):
  File "C:\Users\robur\OpenPype\openpype\tools\loader\widgets.py", line 1578, in _load_representations_by_loader
    options=options
  File "C:\Users\robur\OpenPype\openpype\pipeline\load\utils.py", line 299, in load_with_repre_context
    return loader.load(repre_context, name, namespace, options)
  File "C:\Users\robur\OpenPype\openpype\hosts\hiero\plugins\load\load_effects.py", line 65, in load
    data_imprint
  File "C:\Users\robur\OpenPype\openpype\hosts\hiero\plugins\load\load_effects.py", line 122, in _shared_loading
    node[knob_name].setValue(knob_value)
ValueError: expecting a sequence of 2 floats, 200 found

Also, last efect loaded overwrites previous one when more than one plate has published effect for the same shot.

image

image

Copy link
Collaborator

@jrsndl jrsndl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described, even with multiple effects and animated transforms.
Tested in Hiero 13.2

@jakubjezek001
Copy link
Member Author

@jrsndl please test it one more. I have found some bugs on Centos.

@jakubjezek001 jakubjezek001 removed this from the next-patch milestone Nov 10, 2022
@64qam
Copy link
Member

64qam commented Nov 11, 2022

With this PR, Openpype menu is not integrated into Hiero 12 and Nuke Studio 12.

@jakubjezek001
Copy link
Member Author

With this PR, Openpype menu is not integrated into Hiero 12 and Nuke Studio 12.

I have fixed this. Please try again.

@jakubjezek001 jakubjezek001 merged commit 719aa11 into develop Nov 21, 2022
@jakubjezek001 jakubjezek001 deleted the feature/OP-4201_Load-effectPlates-from-Hiero branch November 21, 2022 11:08
@github-actions github-actions bot added this to the next-patch milestone Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Hiero type: feature Larger, user affecting changes and completely new things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants