Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Find executable enhancement #4137

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Nov 24, 2022

Brief description

Enhance how executables are found when find_executable is called which cause that oiiotools return full path to executable.

Description

Modified function find_executable which can now also fill extension to path to executable if is missing. With this change oiiotools return full path to executable with extension.

Additional information

Proper fix of previous issue from PR #4136 .

Testing notes:

Open Tray > Admin > Console and run this script:

from openpype.lib import get_oiio_tools_path

print(get_oiio_tools_path("oiiotool"))
print(get_oiio_tools_path("maketx"))

Output on windows should return full path to executabls with extensions. It should also still work on linux and mac (if the executables are available there).

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 24, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Nov 24, 2022
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

image

@iLLiCiTiT iLLiCiTiT merged commit 6ccd3ee into develop Nov 24, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/find_executable_enhancement branch November 24, 2022 16:43
@github-actions github-actions bot added this to the next-patch milestone Nov 24, 2022
@jakubjezek001 jakubjezek001 modified the milestones: 3.14.7, next-patch Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants