Feature/op 3924 implement ass extractor #4188

tokejepsen · 2022-12-06T21:38:50Z

Brief description

Reviewable ass extractor improvements.

Description

I cant push directly to the OpenPype branch, so going through my personal fork instead. There are a lot of changes because I've merged in latest develop, so to get a better overview of the file changes we need to merge develop.

This is feature parallel to client extractor, with settings ported to OpenPype workflows with objectset and project settings.

Discussion

I don't agree with having an exportSequence attribute because in OpenPype workflows you can define frame range easily, so it makes more sense to just support single frame publishes (which it already does). I propose to remove this attribute to simplify code and workflow.
So to note, current workflow of using current frame to export is prone to user errors and unpredictability.

Testing notes:

Create and publish Ass instance.
Use Arnold's kick executable to validate renders.

…d-clip-with-colorspace-remapping Flame: Loading clip with native colorspace resolved from mapping

…se-extension Webpublisher: extension is lowercased in Setting and in uploaded files

…published_hook Fix - typo in copy last published hook

…r where is looking for versions

…er_with_more_info Ftrack: Event server status give more information about version locations

Online family for Tray Publisher

…nd-reset-tab Nuke: loaded nodes set to first tab

…rst-frame Nuke: load image first frame

…ctPlates-from-Hiero Hiero: loading effect family to timeline

…attribute

…ested version

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

…next_animation Publisher: Easy access to publish page from create page

…l_source General: Integrate thumbnail looks for thumbnail to multiple places

…sactions-Handle-cases-when-source-and-destination-is-the-same File transactions: Source path is destination path

…ltipart_fix General: Oiio conversion multipart fix

…t-viewer-and-display-regex-fix Nuke: correct detection of viewer and display

…ed_enhancement General: Collection Audio speed up

- use lib for attribute context - remove mask class method

ynbot · 2022-12-06T21:38:53Z

Task linked: OP-3924 Implement ASS Extractor

hound

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/usr/local/bin/flake8", line 8, in 
    sys.exit(main())
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File "/usr/lib/python3.8/ast.py", line 379, in generic_visit
    self.visit(item)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.8/ast.py", line 381, in generic_visit
    self.visit(value)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'

hound · 2022-12-06T21:39:42Z

openpype/hosts/houdini/plugins/create/convert_legacy.py

+ if not self.legacy_subsets:
+ return
+ self.add_convertor_item("Found {} incompatible subset{}.".format(
+ len(self.legacy_subsets), "s" if len(self.legacy_subsets) > 1 else "")


line too long (82 > 79 characters)

hound · 2022-12-06T21:39:42Z

openpype/tools/publisher/window.py

+ new_item["label"] = new_item.pop("creator_label")
+ new_item["identifier"] = new_item.pop("creator_identifier")
+ new_failed_info.append(new_item)
+ self.add_error_message_dialog(event["title"], new_failed_info, "Creator:")


line too long (82 > 79 characters)

hound · 2022-12-06T21:39:42Z

openpype/hosts/houdini/plugins/publish/validate_workfile_paths.py


+from openpype.pipeline.publish import RepairAction


redefinition of unused 'RepairAction' from line 8

hound · 2022-12-06T21:39:43Z

openpype/hosts/photoshop/plugins/publish/extract_review.py

+ thumbnail_path
+ ]
+ self.log.debug("thumbnail args:: {}".format(args))
+ _output = run_subprocess(args)


local variable '_output' is assigned to but never used

hound · 2022-12-06T21:39:43Z

openpype/hosts/photoshop/plugins/publish/extract_review.py

 mov_path
 ]
 self.log.debug("mov args:: {}".format(args))
- output = run_subprocess(args)
- self.log.debug(output)
+ _output = run_subprocess(args)


local variable '_output' is assigned to but never used

hound · 2022-12-06T21:39:44Z

openpype/pipeline/create/context.py

+ try:
+ convertor.find_instances()
+
+ except:


Do not use bare except:, it also catches unexpected events like memory errors, interrupts, system exit, and so on. Prefer except Exception:. If you're sure what you're doing, be explicit and write except BaseException:.
do not use bare 'except'

hound · 2022-12-06T21:39:44Z

openpype/pipeline/create/context.py

+ exc_info = sys.exc_info()
+ self.log.warning(error_message.format(identifier, exc_info[1]))
+
+ except:


Do not use bare except:, it also catches unexpected events like memory errors, interrupts, system exit, and so on. Prefer except Exception:. If you're sure what you're doing, be explicit and write except BaseException:.
do not use bare 'except'

hound · 2022-12-06T21:39:44Z

openpype/pipeline/create/context.py

+ exc_info = sys.exc_info()
+ self.log.warning(error_message.format(identifier, exc_info[1]))
+
+ except:


Do not use bare except:, it also catches unexpected events like memory errors, interrupts, system exit, and so on. Prefer except Exception:. If you're sure what you're doing, be explicit and write except BaseException:.
do not use bare 'except'

hound · 2022-12-06T21:39:45Z

openpype/tools/publisher/control_qt.py

+
+ @abstractmethod
+ def _send_instance_changes_to_client(self):
+ instance_changes = self._get_instance_changes_for_client()


local variable 'instance_changes' is assigned to but never used

hound · 2022-12-06T21:39:45Z

openpype/tools/publisher/widgets/card_view_widgets.py

+ self._explicitly_selected_groups.append(group_name)
+ new_widget.set_selected(True)
+
+ def _select_item_extend_to(self, instance_id, group_name, new_widget):


'InstanceCardView._select_item_extend_to' is too complex (36)

tokejepsen · 2022-12-06T22:58:31Z

It might also be useful to explore with the client whether using renderlayers is a better options than objectsets. The objectsets workflow is a bit like a blackbox, unless you are very confident in using the pipeline. Using renderlayers would mean that you could test the renders in Maya, then it's "just" a matter of implementation to convert renderlayers to ass files.

jakubjezek001 and others added 30 commits November 18, 2022 13:54

Merge pull request ynput#4079 from pypeclub/feature/OP-4364_Flame-loa…

a375af6

…d-clip-with-colorspace-remapping Flame: Loading clip with native colorspace resolved from mapping

include secrets module to python_2 vendor

69ddc20

Merge branch 'develop' into feature/OP-4201_Load-effectPlates-from-Hiero

e81fd2d

Merge pull request ynput#4095 from pypeclub/bugfix/OP-4394_WP-lowerca…

b872f24

…se-extension Webpublisher: extension is lowercased in Setting and in uploaded files

enhance speed of collect audio by converting it to context plugin

64a1e55

Fix - typo

2db4cc4

Merge pull request ynput#4111 from pypeclub/bugfix/typo_in_copy_last_…

a9a5f71

…published_hook Fix - typo in copy last published hook

add more information about where ftrack service is storing versions o…

d076de0

…r where is looking for versions

Nuke: load image first frame

996cf3d

Nuke: reset tab to first native tab

8d1e720

nuke: close property panel after node creation

c06f689

[Automated] Merged develop into main

2621f61

[Automated] Bump version

554b3b2

[Automated] Merged main into develop

4139753

aov Filtering

33974c3

Merge pull request ynput#4112 from pypeclub/feature/ftrack_event_serv…

806d513

…er_with_more_info Ftrack: Event server status give more information about version locations

Merge pull request ynput#4093 from pypeclub/enhancement/online-family

e8ce60f

Online family for Tray Publisher

Merge pull request ynput#4114 from pypeclub/bugfix/nuke-close-panel-a…

06d5275

…nd-reset-tab Nuke: loaded nodes set to first tab

Merge pull request ynput#4113 from pypeclub/bugfix/nuke-load-image-fi…

59ae120

…rst-frame Nuke: load image first frame

Merge pull request ynput#4055 from pypeclub/feature/OP-4201_Load-effe…

719aa11

…ctPlates-from-Hiero Hiero: loading effect family to timeline

rename families_to_upload to families_to_review + define it as class …

94939e4

…attribute

Added helper class for version resolving and sorting

cdb91c0

Use full version for resolving and use specific build if matches requ…

b1e899d

…ested version

few formatting changes

dbc7250

change order of default value

61e5dc3

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

Merge pull request ynput#4058 from pypeclub/feature/publisher_create_…

0f4f888

…next_animation Publisher: Easy access to publish page from create page

attribute definitions can be hidden and disabled

e24c2f8

added special definition for hidden values

6abfa14

implemented hidden widget

fe392aa

enhanced attribute definitons widget

068ec3f

iLLiCiTiT and others added 21 commits December 6, 2022 15:14

store thumbnail path to instance data

21411d5

change order of thumbnail path resolving

aa704b4

move unpublished representations logic to separated method

608afc3

Merge pull request ynput#4181 from pypeclub/bugfix/integrate_thumbnai…

272fd1e

…l_source General: Integrate thumbnail looks for thumbnail to multiple places

normalize paths when added to queue

c764dc2

skip if source and destination are the same paths

18a9c55

formatting changes

36dcab1

removed redundant check of directory

ee71a05

remove unused variable

9f2cd89

remove source and destination check from integrate

2c55ee5

Merge pull request ynput#4184 from pypeclub/feature/OP-4566_File-tran…

2e17bf4

…sactions-Handle-cases-when-source-and-destination-is-the-same File transactions: Source path is destination path

Merge pull request ynput#4060 from pypeclub/bugfix/oiio_conversion_mu…

2d5969a

…ltipart_fix General: Oiio conversion multipart fix

Merge pull request ynput#4165 from pypeclub/bugfix/OP-4555-Nuke-detec…

c67a0b5

…t-viewer-and-display-regex-fix Nuke: correct detection of viewer and display

Merge pull request ynput#4110 from pypeclub/feature/collect_audio_spe…

a99c4a8

…ed_enhancement General: Collection Audio speed up

Remove redundant infected code

1fc8528

Creator settings

fd63457

Collect camera from objectset if present.

3cf47e2

Working extractor

76bf9bf

Merge branch 'develop' into feature/OP-3924_implement-ass-extractor

3b1f69a

Remove redundant lib

31d14cb

Refactor

b974c67

- use lib for attribute context - remove mask class method

tokejepsen requested a review from antirotor December 6, 2022 21:39

tokejepsen self-assigned this Dec 6, 2022

hound bot reviewed Dec 6, 2022

View reviewed changes

tokejepsen added type: enhancement Enhancements to existing functionality host: Maya labels Dec 6, 2022

antirotor merged commit 14e6d0f into ynput:feature/OP-3924_implement-ass-extractor Dec 8, 2022

BigRoy mentioned this pull request Apr 5, 2023

Maya: Refactor to new publisher #4388

Merged

65 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/op 3924 implement ass extractor #4188

Feature/op 3924 implement ass extractor #4188

tokejepsen commented Dec 6, 2022

ynbot commented Dec 6, 2022

hound bot left a comment

hound bot Dec 6, 2022

hound bot Dec 6, 2022

hound bot Dec 6, 2022

hound bot Dec 6, 2022

hound bot Dec 6, 2022

hound bot Dec 6, 2022

hound bot Dec 6, 2022

hound bot Dec 6, 2022

hound bot Dec 6, 2022

hound bot Dec 6, 2022

tokejepsen commented Dec 6, 2022

Feature/op 3924 implement ass extractor #4188

Feature/op 3924 implement ass extractor #4188

Conversation

tokejepsen commented Dec 6, 2022

Brief description

Description

Discussion

Testing notes:

ynbot commented Dec 6, 2022

hound bot left a comment

Choose a reason for hiding this comment

hound bot Dec 6, 2022

Choose a reason for hiding this comment

hound bot Dec 6, 2022

Choose a reason for hiding this comment

hound bot Dec 6, 2022

Choose a reason for hiding this comment

hound bot Dec 6, 2022

Choose a reason for hiding this comment

hound bot Dec 6, 2022

Choose a reason for hiding this comment

hound bot Dec 6, 2022

Choose a reason for hiding this comment

hound bot Dec 6, 2022

Choose a reason for hiding this comment

hound bot Dec 6, 2022

Choose a reason for hiding this comment

hound bot Dec 6, 2022

Choose a reason for hiding this comment

hound bot Dec 6, 2022

Choose a reason for hiding this comment

tokejepsen commented Dec 6, 2022