This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
fixed condition for multipartExr #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multipartExr tag was looked up in representation tags instead of instance data
|
this release has been close, if you want to make it a hotfix, it needs to go to master |
|
changed destination to master |
mkolar
approved these changes
May 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ffpmeg is not supporting multipart exrs therefor we introduced
multipartExrproperty to pass that information down the line so extractor avoid running ffmpeg against those data.Unfortunately those extractors were looking for it in wrong place - in tags on representation, but should look instead at instance data.
This bug resulted in inability to publish renders with multipart exrs as ffmpeg always crashed.