This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Feature/harmony publish template #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkolar
reviewed
May 25, 2020
| @@ -81,7 +81,8 @@ class IntegrateAssetNew(pyblish.api.InstancePlugin): | |||
| "assembly", | |||
| "fbx", | |||
| "textures", | |||
| "action" | |||
| "action", | |||
| "template" | |||
There was a problem hiding this comment.
I think we should be more specific with this family. Template sounds too generic, considering it's only harmony compatible family. How about harmony.template or something specific like that
There was a problem hiding this comment.
Sure, harmony.template sounds good.
Was looking at nukenodes but like the dot notation better.
|
I dont have merge rights, if thats what you wanted me to do? @mkolar |
|
my bad. merging now. |
mkolar
approved these changes
May 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/pypeclub/fourthwall-config/issues/3