Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

feature/213 move pyblish to tools #227

Merged
merged 9 commits into from
Jun 10, 2020
Merged

Conversation

iLLiCiTiT
Copy link
Member

What's new

Current pyblish-lite fork moved to pype/tools and renamed to pyblish_pype.

Required repos:

  • pype
  • pype-config
  • pype-setup

How to test:

1.) Pull branches feature/213_move_pyblish_to_tools on required repos.
2.) Remove pyblish-lite from ~/pype-setup/repos/.
3.) Run any host as usually and run publish.

Changes connected to this change:

  • removed pyblish-lite from deploy in pype-setup
  • changed PYBLISH_GUI to pyblish_pype
  • added pype/tools to PYTHONPATH in global.json
  • enivornment PYBLISH_LITE_ALWAYS_EXEC renamed to PYBLISH_GUI_ALWAYS_EXEC

resolves #213

@iLLiCiTiT iLLiCiTiT self-assigned this Jun 5, 2020
@mkolar mkolar added this to the 3.0 milestone Jun 7, 2020
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine. but can we please fix the hound errors?

Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

./pype/tools/pyblish_pype/model.py:979:34: B008: Do not perform function call...
./pype/tools/pyblish_pype/model.py:979:34: B008: Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
./pype/tools/pyblish_pype/model.py:983:31: B008: Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
./pype/tools/pyblish_pype/model.py:1008:41: B008: Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.

pype/tools/pyblish_pype/widgets.py Show resolved Hide resolved
pype/tools/pyblish_pype/widgets.py Show resolved Hide resolved
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

./pype/tools/pyblish_pype/model.py:979:34: B008: Do not perform function call...
./pype/tools/pyblish_pype/model.py:979:34: B008: Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
./pype/tools/pyblish_pype/model.py:983:31: B008: Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
./pype/tools/pyblish_pype/model.py:1008:41: B008: Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.

Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

./pype/tools/pyblish_pype/model.py:979:34: B008: Do not perform function call...
./pype/tools/pyblish_pype/model.py:979:34: B008: Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
./pype/tools/pyblish_pype/model.py:983:31: B008: Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
./pype/tools/pyblish_pype/model.py:1008:41: B008: Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.

Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

./pype/tools/pyblish_pype/model.py:979:34: B008: Do not perform function call...
./pype/tools/pyblish_pype/model.py:979:34: B008: Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
./pype/tools/pyblish_pype/model.py:983:31: B008: Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
./pype/tools/pyblish_pype/model.py:1008:41: B008: Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.

@iLLiCiTiT
Copy link
Member Author

works fine. but can we please fix the hound errors?
@mkolar should be done

@mkolar mkolar merged commit 96609f5 into develop Jun 10, 2020
@mkolar mkolar deleted the feature/213_move_pyblish_to_tools branch July 8, 2020 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add publish gui to pype tools
2 participants