nks cut reference videos

[jakubjezek001]

• cleanup global plugin code
• adding nks plugin for cutting asset review videos bigger file

This picture is showing the problem. Sometimes an input video defined as review family member has source video material only for part of the required subset properties. Either it is shorter as handles are missing at the start or the end of the clip, or it is far too long and needs to be shortened.

This plugin is taking the source video file from the representation created in NKS CollectReviews where it has been tagged with either _cut-bigger or _cut-smaller nonpublic tags.

Then after missing material is identified will add black empty frames on the spot where it should be.

Schema is explaining the details of procedure.

[hound]

'ExtractReview.process' is too complex (40)
too many blank lines (2)

[mkolar]

This needs to be able to work also with clips that are already cut to the correct length. Currently if we have handles in tags, but the video itself is cut to length without handles, we're still able to publish ad have correct metadata on the shot. We must make sure that even in this case (and if no-handles tag is in extractReview), we will be passing on the correct frame ranges.

As discussed on the call, we'll extend each clip to it's full length with handles by copying a proxy frame before and after the footage. This will ensure that even plates with missing material can be published and worked on.

[iLLiCiTiT]

So what you say that in case of python3, you would still prefer "string".format(dict) rather then f-string?

For publish plugins where function has more than 50 lines, yes I prefer old formating (rather with args than dict). But like you've said it's my preferation.

[mkolar]

@jezscha can you please write explanation of what it does now exactly? I can't get it to work. Some cutting is happening, but can't get past review extractor.

[jakubjezek001]

@jezscha can you please write explanation of what it does now exactly? I can't get it to work. Some cutting is happening, but can't get past review extractor.

yeah I was just working on the schema @mkolar I hope it is more clear now ;)

[mkolar]

Still having issues publishing with this

Instance: 
plateMain_sq1001sh010
Line: 
112
Traceback: 
Traceback (most recent call last):
  File "C:\code\pype-setup\repos\pyblish-base\pyblish\plugin.py", line 517, in __explicit_process
    runner(*args)
  File "C:\code\pype-setup\repos\pype\pype\plugins\nukestudio\publish\extract_review_cutup_video.py", line 213, in process
  File "C:\code\pype-setup\repos\pype\pype\lib.py", line 112, in _subprocess
    raise ValueError("\"{}\" was not successful: {}".format(args, output))
ValueError: "('C:\\code\\pype-setup\\vendor\\bin\\ffmpeg_exec\\windows\\bin\\ffmpeg -f lavfi -i "color=c=black:s=1920x1080:r=25.0" -ss 0.00 -t 0.32 -i C:/projects/milan_testing/resources/2d\\sq1001.mov -filter_complex "[0]trim=duration=0.08[gv0];[gv0][1:v]concat=n=2:v=1" -c:v copy -intra -y C:/projects/milan_testing/resources/2d\\cuts\\sq1001sh010_sq1001.mov',)" was not successful: ffmpeg version 4.1.3 Copyright (c) 2000-2019 the FFmpeg developers 
  built with gcc 8.3.1 (GCC) 20190414 
  configuration: --enable-gpl --enable-version3 --enable-sdl2 --enable-fontconfig --enable-gnutls --enable-iconv --enable-libass --enable-libbluray --enable-libfreetype --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-libopus --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libtheora --enable-libtwolame --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxml2 --enable-libzimg --enable-lzma --enable-zlib --enable-gmp --enable-libvidstab --enable-libvorbis --enable-libvo-amrwbenc --enable-libmysofa --enable-libspeex --enable-libxvid --enable-libaom --enable-libmfx --enable-amf --enable-ffnvcodec --enable-cuvid --enable-d3d11va --enable-nvenc --enable-nvdec --enable-dxva2 --enable-avisynth 
  libavutil      56. 22.100 / 56. 22.100 
  libavcodec     58. 35.100 / 58. 35.100 
  libavformat    58. 20.100 / 58. 20.100 
  libavdevice    58.  5.100 / 58.  5.100 
  libavfilter     7. 40.101 /  7. 40.101 
  libswscale      5.  3.100 /  5.  3.100 
  libswresample   3.  3.100 /  3.  3.100 
  libpostproc    55.  3.100 / 55.  3.100 
Input #0, lavfi, from 'color=c=black:s=1920x1080:r=25.0': 
  Duration: N/A, start: 0.000000, bitrate: N/A 
    Stream #0:0: Video: rawvideo (I420 / 0x30323449), yuv420p, 1920x1080 [SAR 1:1 DAR 16:9], 25 tbr, 25 tbn, 25 tbc 
Input #1, mov,mp4,m4a,3gp,3g2,mj2, from 'C:/projects/milan_testing/resources/2d\sq1001.mov': 
  Metadata: 
    major_brand     : qt   
    minor_version   : 512 
    compatible_brands: qt   
    uk.co.thefoundry.Application: Nuke 
    uk.co.thefoundry.ApplicationVersion: 11.3v1 
    uk.co.thefoundry.YCbCrMatrix: Rec 709 
    uk.co.thefoundry.Colorspace: sRGB 
    uk.co.thefoundry.Writer: mov64 
  Duration: 00:00:00.60, start: 0.000000, bitrate: 135860 kb/s 
    Stream #1:0(eng): Video: prores (ap4h / 0x68347061), yuv444p10le(tv, bt709/unknown/unknown, progressive), 1920x1080, 135836 kb/s, SAR 1:1 DAR 16:9, 25 fps, 25 tbr, 2500 tbn, 2500 tbc (default) 
    Metadata: 
      handler_name    : VideoHandler 
      encoder         : Apple ProRes 4444 
      timecode        : 00:57:36:00 
    Stream #1:1(eng): Data: none (tmcd / 0x64636D74), 0 kb/s 
    Metadata: 
      handler_name    : TimeCodeHandler 
      timecode        : 00:57:36:00 
Streamcopy requested for output stream 0:0, which is fed from a complex filtergraph. Filtering and streamcopy cannot be used together. 

[jakubjezek001]

Still having issues publishing with this
ValueError: "('C:\code\pype-setup\vendor\bin\ffmpeg_exec\windows\bin\ffmpeg -f lavfi -i

could you send me those files for testing please? cannot replicate the issue on my side..

[jakubjezek001]

Still having issues publishing with this
ValueError: "('C:\code\pype-setup\vendor\bin\ffmpeg_exec\windows\bin\ffmpeg -f lavfi -i

could you send me those files for testing please? cannot replicate the issue on my side..

@mkolar so I have found it so no worries it is fixed with 5bfafb2